Re: [PATCH v6 02/11] mfd: intel-m10-bmc: Create m10bmc_platform_info for type specific info

Lee Jones
2023-01-27T10:28:52Z

On Mon, 16 Jan 2023, Ilpo Järvinen wrote:

> BMC type specific info is currently set by a switch/case block. The
> size of this info is expected to grow as more dev types and features
> are added which would have made the switch block bloaty.
>
> Store type specific info into struct and place them into .driver_data
> instead because it makes things a bit cleaner.
>
> The m10bmc_type enum can be dropped as the differentiation is now
> fully handled by the platform info.
>
> The info member of struct intel_m10bmc that is added here is not used
> yet in this change but its addition logically still belongs to this
> change. The CSR map change that comes after this change needs to have
> the info member.
>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/mfd/intel-m10-bmc.c | 53 ++++++++++++++-----------------
> include/linux/mfd/intel-m10-bmc.h | 12 +++++++
> 2 files changed, 36 insertions(+), 29 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]