Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")

Jeroen Roovers
2023-01-30T17:46:05Z

On Sun, 29 Jan 2023 20:53:08 +0100
Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:

> Spell them as "default" and "heartbeat".
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h
> b/drivers/net/ethernet/dec/tulip/tulip.h index
> 0ed598dc7569c..10d7d8de93660 100644 ---
> a/drivers/net/ethernet/dec/tulip/tulip.h +++
> b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum
> t21143_csr6_bits { csr6_ttm = (1<<22), /* Transmit Threshold Mode,
> set for 10baseT, 0 for 100BaseTX */ csr6_sf = (1<<21), /* Store and
> forward. If set ignores TR bits */ csr6_hbd = (1<<19), /* Heart beat
> disable. Disables SQE function in 10baseT */

If you are going to put "heartbeat" in the title of the patch, you may
want to fix "Heart beat" to match here as well. :-)

Kind regards,
jer