From: Greg KH <gregkh@linuxfoundation.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: stable@vger.kernel.org, Chun-Tse Shao <ctshao@google.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH 5.15.y] kbuild: Allow kernel installation packaging to override pkg-config
Date: Mon, 30 Jan 2023 11:22:25 +0100 [thread overview]
Message-ID: <Y9eaYcJl52ub5dAl@kroah.com> (raw)
In-Reply-To: <CAE-0n52wiAiHACFXeki6w7hfn3swuUp6jK6gpFvPxfrnmcV0TQ@mail.gmail.com>
On Tue, Jan 17, 2023 at 12:09:29PM -0800, Stephen Boyd wrote:
> Quoting Greg KH (2023-01-14 05:49:09)
> > On Thu, Jan 12, 2023 at 04:21:49PM -0800, Stephen Boyd wrote:
> > > From: Chun-Tse Shao <ctshao@google.com>
> > >
> > > commit d5ea4fece4508bf8e72b659cd22fa4840d8d61e5 upstream.
> > >
> > > Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override
> > > what pkg-config and parameters are used.
> > >
> > > Signed-off-by: Chun-Tse Shao <ctshao@google.com>
> > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > > [swboyd@chromium.org: Drop certs/Makefile hunk that doesn't
> > > apply because pkg-config isn't used there, add dtc/Makefile hunk to
> > > fix dtb builds]
> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > > ---
> > >
> > > I need this to properly compile 5.15.y stable kernels in the chromeos
> > > build system.
> >
> > Is this a new issue? A regression? This feels odd to add a new build
> > feature to an old kernel when nothing changed to require it other than
> > an external tool suddenly requiring something new?
> >
>
> The chromeos build system checks for pkg-config being called directly
> and fails the build if the proper wrapper isn't used. We set
> HOSTPKG_CONFIG in the environment when building the kernel so that it
> doesn't fail.
>
> It's not exactly a new issue, but a self-inflicted one that makes
> building the stable kernel annoying. I figured it was similar to fixing
> problems with compiling stable kernels with newer toolchains, but if it
> feels odd then I'll just have to remember to pick this patch whenever
> bisecting stable trees. No worries.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-30 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 0:21 [PATCH 5.15.y] kbuild: Allow kernel installation packaging to override pkg-config Stephen Boyd
2023-01-14 13:49 ` Greg KH
2023-01-17 20:09 ` Stephen Boyd
2023-01-30 10:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9eaYcJl52ub5dAl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ctshao@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox