From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: soc: remove layering violation for the soc_bus
Date: Tue, 31 Jan 2023 09:08:41 +0100 [thread overview]
Message-ID: <Y9jMiQPLaMjIvaq/@kroah.com> (raw)
In-Reply-To: <CAJZ5v0jjSoNchvdDacQjakscsSK6d535Ruqd=OR_nYz4nMNwVQ@mail.gmail.com>
On Mon, Jan 30, 2023 at 07:51:11PM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 30, 2023 at 7:49 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > The soc_bus code pokes around in the internal bus structures assuming
> > that it "knows" if a field is not set that it has not been registered
> > yet. That isn't a safe assumption, so just remove the layering
> > violation entirely and keep track if the bus has been registered or not
> > ourselves.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks for the quick review!
prev parent reply other threads:[~2023-01-31 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 17:10 [PATCH] driver core: soc: remove layering violation for the soc_bus Greg Kroah-Hartman
2023-01-30 18:51 ` Rafael J. Wysocki
2023-01-31 8:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9jMiQPLaMjIvaq/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox