Re: [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

Dmitry Baryshkov
2023-01-20T20:33:59Z

On 20 January 2023 18:32:47 GMT+03:00, Sean Paul <sean@poorly.run> wrote:
>On Thu, Jan 19, 2023 at 11:37:52AM +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 20:30, Mark Yacoub wrote:
>> > From: Sean Paul <seanpaul@chromium.org>
>> >
>> > This patch moves the hdcp atomic check from i915 to drm_hdcp so other
>> > drivers can use it. No functional changes, just cleaned up some of the
>> > code when moving it over.
>> >
>> > Acked-by: Jani Nikula <jani.nikula@intel.com>
>> > Acked-by: Jani Nikula <jani.nikula@intel.com>
>> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
>> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
>> > Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
>> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-2-sean@poorly.run #v1
>> > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-2-sean@poorly.run #v2
>> > Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-2-sean@poorly.run #v3
>> > Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-2-sean@poorly.run #v4
>> > Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-2-sean@poorly.run #v5
>>
>> It seems all your previous versions were sent not to correct people and
>> lists. Therefore we see it for the first time even though it is v6!
>
>Hi Krzysztof,
>Thanks for your review comments.
>
>Here are the addresses the last version was sent to, who is missing?
>
>To: dri-devel@lists.freedesktop.org,
> jani.nikula@intel.com,
> intel-gfx@lists.freedesktop.org,
> freedreno@lists.freedesktop.org,
> rodrigo.vivi@intel.com
>Cc: bjorn.andersson@linaro.org,
> swboyd@chromium.org,
> abhinavk@codeaurora.org,
> markyacoub@chromium.org,
> Sean Paul <seanpaul@chromium.org>,
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
> Maxime Ripard <mripard@kernel.org>,
> Thomas Zimmermann <tzimmermann@suse.de>,
> David Airlie <airlied@linux.ie>,
> Daniel Vetter <daniel@ffwll.ch>,
> Jani Nikula <jani.nikula@linux.intel.com>,
> Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>
>> It's
>> not the first such weird CC list in chromium, so maybe your
>> organisational process could be improved? Not only for you but for
>> colleagues as well, so you all start using get_maintainers.pl on newest
>> kernel (not something ancient)?
>
>I can't really speak for others, but I use MAINTAINERS from drm-tip. The
>previous patch sets were sent before 24df12013853 ("MAINTAINERS: Add
>Dmitry as MSM DRM driver co-maintainer"), which might explain why you think
>there are absences?

Current iteration of the patchset got at least three addresses wrong. They have been changed for various reasons. Thus I also can suppose that the list is incomplete and/or incorrect.

>
>Thanks again,
>
>Sean
>
>>
>> Best regards,
>> Krzysztof
>>
>

--
With best wishes
Dmitry