public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jesper Juhl <jesperjuhl76@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
	David Howells <dhowells@redhat.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] Remove a number of duplicate includes
Date: Wed, 1 Feb 2023 05:48:05 +0100	[thread overview]
Message-ID: <Y9nvBbGcwZkQbOGN@kroah.com> (raw)
In-Reply-To: <52d6ec2f-417c-8bc5-ed35-72229fc8d7a0@gmail.com>

On Tue, Jan 31, 2023 at 10:27:23PM +0100, Jesper Juhl wrote:
> > From 09d653f07a8bbb2aea52b735a731ca781f5f401c Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Thu, 26 Jan 2023 02:16:59 +0100
> Subject: [PATCH] Remove a number of duplicate includes

Why is this in the body of the changelog?


> 
> Including the same header multiple times when there's no functional reason
> to do so is just pointless clutter and potentially slows down builds.
> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> ---
>  drivers/base/node.c                     | 1 -
>  drivers/bus/bt1-apb.c                   | 1 -
>  drivers/char/hw_random/core.c           | 1 -
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 -
>  drivers/gpu/drm/drm_gem_shmem_helper.c  | 1 -
>  fs/fscache/io.c                         | 1 -
>  fs/overlayfs/inode.c                    | 1 -
>  kernel/sched/build_utility.c            | 1 -
>  kernel/sched/core.c                     | 3 ---
>  kernel/sched/fair.c                     | 2 --
>  10 files changed, 13 deletions(-)

Please properly split this up into subsystem-related patches and send
them that way.

thanks,

greg k-h

  reply	other threads:[~2023-02-01  4:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 21:27 [PATCH] Remove a number of duplicate includes Jesper Juhl
2023-02-01  4:48 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-27 23:19 Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9nvBbGcwZkQbOGN@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dhowells@redhat.com \
    --cc=jesperjuhl76@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox