From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
linux-gpio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] gpiolib: remove gpio_set_debounce
Date: Wed, 1 Feb 2023 11:07:35 -0800 [thread overview]
Message-ID: <Y9q4d50lSdPn8myb@google.com> (raw)
In-Reply-To: <Y9qwJtOaKrgB5n+T@smile.fi.intel.com>
On Wed, Feb 01, 2023 at 08:32:06PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 31, 2023 at 09:44:31PM -0800, Dmitry Torokhov wrote:
> > On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:
>
> ...
>
> > > - return !gpio_get_value(ts->gpio_pendown);
> > > + return !gpiod_get_value(ts->gpio_pendown);
> >
> > No, we can not blindly do that without checking annotations on GPIOs.
>
> But this is easy to fix, i.e. use raw API, no?
I'd rather not (I hope I can make this driver respect declared polarity
at some point), so for debounce we could do:
gpiod_set_debounce(gpio_to_gpiod(), ...);
in ads7846 for now, and get rid of gpio_set_debounce() as a publc API.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-02-01 19:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 10:11 [PATCH v2 0/7] gpiolib cleanups Arnd Bergmann
2023-01-27 10:11 ` [PATCH v2 1/7] gpiolib: remove empty asm/gpio.h files Arnd Bergmann
2023-01-27 13:34 ` Linus Walleij
2023-01-27 10:11 ` [PATCH v2 2/7] gpiolib: coldfire: remove custom asm/gpio.h Arnd Bergmann
2023-01-27 13:34 ` Linus Walleij
2023-01-27 10:11 ` [PATCH v2 3/7] gpiolib: remove asm-generic/gpio.h Arnd Bergmann
2023-01-27 10:41 ` Andy Shevchenko
2023-01-27 13:35 ` Linus Walleij
2023-01-27 10:11 ` [PATCH v2 4/7] gpiolib: remove gpio_set_debounce Arnd Bergmann
2023-01-27 10:51 ` Andy Shevchenko
2023-01-27 13:35 ` Linus Walleij
2023-02-01 5:44 ` Dmitry Torokhov
2023-02-01 18:32 ` Andy Shevchenko
2023-02-01 19:07 ` Dmitry Torokhov [this message]
2023-02-07 11:25 ` Andy Shevchenko
2023-02-07 14:34 ` Arnd Bergmann
2023-01-27 10:11 ` [PATCH v2 5/7] gpiolib: remove legacy gpio_export Arnd Bergmann
2023-01-27 13:36 ` Linus Walleij
2023-01-27 10:11 ` [PATCH v2 6/7] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Arnd Bergmann
2023-01-27 13:39 ` Linus Walleij
2023-01-27 14:07 ` Arnd Bergmann
2023-01-27 10:11 ` [PATCH v2 7/7] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h Arnd Bergmann
2023-01-27 13:39 ` Linus Walleij
2023-01-27 11:29 ` [PATCH v2 0/7] gpiolib cleanups Andy Shevchenko
2023-01-27 13:57 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9q4d50lSdPn8myb@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).