From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
Jens Axboe <axboe@kernel.dk>,
Philipp Reisner <philipp.reisner@linbit.com>,
Bryan Tan <bryantan@vmware.com>,
Steven Rostedt <rostedt@goodmis.org>,
Eric Dumazet <edumazet@google.com>,
Bob Pearson <rpearsonhpe@gmail.com>,
Ariel Levkovich <lariel@nvidia.com>,
Theodore Ts'o <tytso@mit.edu>, Julian Anastasov <ja@ssi.bg>,
Jiri Wiesner <jwiesner@suse.de>
Subject: Re: [PATCH 10/13] ipvs: Rename kfree_rcu() to kfree_rcu_mightsleep()
Date: Wed, 1 Feb 2023 16:53:43 +0100 [thread overview]
Message-ID: <Y9qLB6Zyx5atcFUV@salvia> (raw)
In-Reply-To: <20230201150954.409693-1-urezki@gmail.com>
Hi,
On Wed, Feb 01, 2023 at 04:09:51PM +0100, Uladzislau Rezki (Sony) wrote:
> The kfree_rcu()'s single argument name is deprecated therefore
> rename it to kfree_rcu_mightsleep() variant. The goal is explicitly
> underline that it is for sleepable contexts.
>
> Cc: Julian Anastasov <ja@ssi.bg>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jiri Wiesner <jwiesner@suse.de>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> net/netfilter/ipvs/ip_vs_est.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_est.c b/net/netfilter/ipvs/ip_vs_est.c
> index ce2a1549b304..a39baf6d1367 100644
> --- a/net/netfilter/ipvs/ip_vs_est.c
> +++ b/net/netfilter/ipvs/ip_vs_est.c
> @@ -549,7 +549,7 @@ void ip_vs_stop_estimator(struct netns_ipvs *ipvs, struct ip_vs_stats *stats)
> __set_bit(row, kd->avail);
> if (!kd->tick_len[row]) {
> RCU_INIT_POINTER(kd->ticks[row], NULL);
> - kfree_rcu(td);
I also found this kfree_rcu() without rcu_head call a few weeks ago.
@Wiesner, @Julian: Any chance this can be turned into kfree_rcu(td, rcu_head); ?
next prev parent reply other threads:[~2023-02-01 15:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:09 [PATCH 10/13] ipvs: Rename kfree_rcu() to kfree_rcu_mightsleep() Uladzislau Rezki (Sony)
2023-02-01 15:09 ` [PATCH 11/13] rcuscale: " Uladzislau Rezki (Sony)
2023-02-01 15:09 ` [PATCH 12/13] doc: Update whatisRCU.rst Uladzislau Rezki (Sony)
2023-02-01 15:09 ` [PATCH 13/13] rcu/kvfree: Eliminate k[v]free_rcu() single argument macro Uladzislau Rezki (Sony)
2023-03-05 10:29 ` Joel Fernandes
2023-03-05 10:49 ` Joel Fernandes
2023-03-05 11:41 ` Uladzislau Rezki
2023-03-05 12:56 ` Joel Fernandes
2023-03-05 18:05 ` Paul E. McKenney
2023-03-06 14:49 ` Joel Fernandes
2023-03-06 15:01 ` Paul E. McKenney
2023-03-06 15:12 ` Joel Fernandes
2023-03-06 16:42 ` Uladzislau Rezki
2023-03-06 16:55 ` Paul E. McKenney
2023-03-06 17:10 ` Uladzislau Rezki
2023-03-06 19:54 ` Joel Fernandes
2023-02-01 15:53 ` Pablo Neira Ayuso [this message]
2023-02-01 16:12 ` [PATCH 10/13] ipvs: Rename kfree_rcu() to kfree_rcu_mightsleep() Julian Anastasov
2023-02-01 16:52 ` Uladzislau Rezki
2023-02-01 17:10 ` Pablo Neira Ayuso
2023-02-01 17:19 ` Uladzislau Rezki
2023-03-09 0:11 ` Joel Fernandes
2023-03-09 9:19 ` Pablo Neira Ayuso
2023-03-10 1:08 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9qLB6Zyx5atcFUV@salvia \
--to=pablo@netfilter.org \
--cc=axboe@kernel.dk \
--cc=bryantan@vmware.com \
--cc=edumazet@google.com \
--cc=ja@ssi.bg \
--cc=jwiesner@suse.de \
--cc=lariel@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksiy.avramchenko@sony.com \
--cc=paulmck@kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rpearsonhpe@gmail.com \
--cc=tytso@mit.edu \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox