From: Sean Christopherson <seanjc@google.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 5/7] kvm: x86/mmu: Move the code out of FNAME(sync_page)'s loop body into mmu.c
Date: Thu, 2 Feb 2023 01:29:29 +0000 [thread overview]
Message-ID: <Y9sR+ffQ99nl4Xyr@google.com> (raw)
In-Reply-To: <20230105095848.6061-6-jiangshanlai@gmail.com>
On Thu, Jan 05, 2023, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
>
> Rename mmu->sync_page to mmu->sync_spte and move the code out
> of FNAME(sync_page)'s loop body into mmu.c.
>
> Also initialize mmu->sync_spte as NULL for direct paging.
Please split this up, we got burned before by making one of the mmu hooks NULL,
I don't want a repeat of that. I.e. nullify the direct hook only when it's
very clear it can't be dereferenced.
next prev parent reply other threads:[~2023-02-02 1:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:58 [PATCH 0/7] kvm: x86/mmu: Share the same code to invalidate each vTLB entry Lai Jiangshan
2023-01-05 9:58 ` [PATCH 1/7] kvm: x86/mmu: Use KVM_MMU_ROOT_XXX for kvm_mmu_invalidate_gva() Lai Jiangshan
2023-02-02 1:21 ` Sean Christopherson
2023-02-03 14:51 ` Lai Jiangshan
2023-02-03 20:54 ` Sean Christopherson
2023-01-05 9:58 ` [PATCH 2/7] kvm: x86/mmu: Use kvm_mmu_invalidate_gva() in kvm_mmu_invpcid_gva() Lai Jiangshan
2023-02-02 1:21 ` Sean Christopherson
2023-01-05 9:58 ` [PATCH 3/7] kvm: x86/mmu: Use kvm_mmu_invalidate_gva() in nested_ept_invalidate_addr() Lai Jiangshan
2023-02-02 1:22 ` Sean Christopherson
2023-01-05 9:58 ` [PATCH 4/7] kvm: x86/mmu: Reduce the update to the spte in FNAME(sync_page) Lai Jiangshan
2023-01-05 9:58 ` [PATCH 5/7] kvm: x86/mmu: Move the code out of FNAME(sync_page)'s loop body into mmu.c Lai Jiangshan
2023-02-02 1:29 ` Sean Christopherson [this message]
2023-01-05 9:58 ` [PATCH 6/7] kvm: x86/mmu: Remove FNAME(invlpg) Lai Jiangshan
2023-02-02 1:30 ` Sean Christopherson
2023-01-05 9:58 ` [PATCH 7/7] kvm: x86/mmu: Remove @no_dirty_log from FNAME(prefetch_gpte) Lai Jiangshan
2023-01-19 0:53 ` [PATCH 0/7] kvm: x86/mmu: Share the same code to invalidate each vTLB entry Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9sR+ffQ99nl4Xyr@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=jiangshanlai@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox