From: Greg KH <gregkh@linuxfoundation.org>
To: Longlong Xia <xialonglong1@huawei.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
chenwandun@huawei.com, wangkefeng.wang@huawei.com,
sunnanyong@huawei.com
Subject: Re: [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req()
Date: Thu, 2 Feb 2023 09:33:15 +0100 [thread overview]
Message-ID: <Y9t1S1Q+DHdfps/t@kroah.com> (raw)
In-Reply-To: <20230202033203.1239239-4-xialonglong1@huawei.com>
On Thu, Feb 02, 2023 at 03:32:03AM +0000, Longlong Xia wrote:
> Because the return value of devtmpfs_*_node() and devtmpfs_submit_req()
> are not used by their callers, change them into void functions.
Why not just fix this up properly and have the callers handle the errors
if they happen? Failures at this level should cause the device to not
be registered, as you have found out.
But only do this for devtmpfs_create_node(), there's no reason that
devtmpfs_delete_node() needs to return a value as there's nothing we can
do when cleaning things up on a remove path. So if you split this patch
into half, I'll be glad to take that now while you work on fixing up the
return path of devtmpfs_create_node().
thanks,
greg k-h
next prev parent reply other threads:[~2023-02-02 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 3:32 [PATCH -next 0/3] cleanup of devtmpfs_*_node() Longlong Xia
2023-02-02 3:32 ` [PATCH -next 1/3] devtmpfs: convert to pr_fmt Longlong Xia
2023-02-02 8:33 ` Greg KH
2023-02-02 3:32 ` [PATCH -next 2/3] devtmpfs: add debug info to handle() Longlong Xia
2023-02-02 8:30 ` Greg KH
2023-02-10 7:33 ` [PATCH -next 0/3] cleanup of devtmpfs_*_node() Longlong Xia
2023-02-10 7:33 ` [PATCH -next 1/3] devtmpfs: add debug info to handle() Longlong Xia
2023-02-10 7:33 ` [PATCH -next 2/3] driver core: add error handling for devtmpfs_create_node() Longlong Xia
2023-02-10 7:33 ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_delete_node() Longlong Xia
2023-02-10 8:17 ` [PATCH -next 0/3] cleanup of devtmpfs_*_node() Greg KH
2023-02-02 3:32 ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Longlong Xia
2023-02-02 8:33 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-02 3:10 [PATCH -next 0/3] cleanup of devtmpfs_*_node() Longlong Xia
2023-02-02 3:10 ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Longlong Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9t1S1Q+DHdfps/t@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chenwandun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xialonglong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox