From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
Alexander Usyskin <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 1/1] mei: Move uuid_le_cmp() to its only user
Date: Thu, 2 Feb 2023 17:21:52 +0200 [thread overview]
Message-ID: <Y9vVENZEjg1e43LT@smile.fi.intel.com> (raw)
In-Reply-To: <20230202151759.GA28861@lst.de>
On Thu, Feb 02, 2023 at 04:17:59PM +0100, Christoph Hellwig wrote:
> On Thu, Feb 02, 2023 at 04:54:12PM +0200, Andy Shevchenko wrote:
> > There is only a single user of uuid_le_cmp() API, let's make it private
> > to that user.
>
> Any reason this code can't just use guid_t and guid_equal?
It's part of ABI, while guid_* are for the internal use.
Eventually they may switch to the internal types, but it's up to MEI.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-02 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:54 [PATCH v1 1/1] mei: Move uuid_le_cmp() to its only user Andy Shevchenko
2023-02-02 15:17 ` Christoph Hellwig
2023-02-02 15:21 ` Andy Shevchenko [this message]
2023-02-02 15:22 ` Christoph Hellwig
2023-02-02 15:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9vVENZEjg1e43LT@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=daniele.ceraolospurio@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox