Re: [PATCH 17/24] rtc: pm8xxx: add copyright notice

Johan Hovold
2023-02-02T10:22:07Z

On Fri, Jan 27, 2023 at 03:14:48PM +0100, Krzysztof Kozlowski wrote:
> On 27/01/2023 14:04, Johan Hovold wrote:
> > On Thu, Jan 26, 2023 at 05:06:20PM +0100, Alexandre Belloni wrote:
> >> On 26/01/2023 15:20:50+0100, Johan Hovold wrote:
> >>> Add a copyright notice for Linaro and add myself as a (primary) author
> >>> of this driver.
> >>>
> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> >>> ---
> >>> drivers/rtc/rtc-pm8xxx.c | 7 ++++++-
> >>> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> >>> index 09816b9f6282..25bdd804b4d2 100644
> >>> --- a/drivers/rtc/rtc-pm8xxx.c
> >>> +++ b/drivers/rtc/rtc-pm8xxx.c
> >>> @@ -1,5 +1,9 @@
> >>> // SPDX-License-Identifier: GPL-2.0-only
> >>> -/* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
> >>> +/*
> >>> + * pm8xxx RTC driver
> >>> + *
> >>> + * Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
> >>> + * Copyright (c) 2023, Linaro Limited
> >>
> >> Is this really useful? The authoritative source is going to be git
> >> anyway.
> >
> > Sure, but in this case the driver ended up being almost completely
> > reworked so I think it is warranted.
>
> Copyright update is an effect of rework, not independent, thus it should
> be squashed with the code doing the rework. Copyright updates on their
> own do not make sense.

I tend to agree, but there can be reasons for adding it separately as in
this case where I wanted to highlight that I was adding a new entry. And
it is still added along with the changes (i.e. as part of the series).

But I'll squash it with the previous patch for v2.

Johan