From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1996C63797 for ; Fri, 3 Feb 2023 09:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232789AbjBCJ4J (ORCPT ); Fri, 3 Feb 2023 04:56:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbjBCJ4I (ORCPT ); Fri, 3 Feb 2023 04:56:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55AF627D58; Fri, 3 Feb 2023 01:56:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F147DB82A29; Fri, 3 Feb 2023 09:56:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 999E2C433D2; Fri, 3 Feb 2023 09:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675418164; bh=yPF/H334aRuYt2PAUE0Uo8r9edAIWn91teehfMtnynI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ge/JZVwJ7decyTDjG4hMAZxaLwf3c2fgVwYslq5qanp+rAkgTbVFHcX6KKJICZVir eDjq6nxlNpeJx2kOI9kGnwkxRq2F4CqTYgCikpHMTvBI2vEHDk36kYTvMJcxZb/kWU srH4sd6m7G4yLc6fEVgZY+eRduHDqFPfFG3kQ37wU1mM7bbM4qDD3noZCOLSugC2w3 i1Yh5esCfzNVRSu9LvtDgqdUFGqmht0ZXBv6skq5hk46VE9I9Apx5fam8UNria8shJ gUp31ZRD1+0I6b1QIwca9PiY1qwjiQT903FAB9yP0umBn+sCJ5YDtTLF+o3gJHl8TE mXoIXnYQm4FjA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pNso3-0000zZ-7v; Fri, 03 Feb 2023 10:56:31 +0100 Date: Fri, 3 Feb 2023 10:56:31 +0100 From: Johan Hovold To: Abel Vesa Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Lorenzo Pieralisi , "vkoul@kernel.org" , Kishon Vijay Abraham I , Manivannan Sadhasivam , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , Neil Armstrong Subject: Re: [PATCH v7 12/12] arm64: dts: qcom: sm8550-mtp: Add PCIe PHYs and controllers nodes Message-ID: References: <20230203081807.2248625-1-abel.vesa@linaro.org> <20230203081807.2248625-13-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203081807.2248625-13-abel.vesa@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2023 at 10:18:07AM +0200, Abel Vesa wrote: > Enable PCIe controllers and PHYs nodes on SM8550 MTP board. > > Co-developed-by: Neil Armstrong > Signed-off-by: Neil Armstrong > Signed-off-by: Abel Vesa > --- > +&pcie_1_phy_aux_clk { > + clock-frequency = <1000>; > +}; > + > +&pcie0 { > + wake-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>; > + perst-gpios = <&tlmm 94 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie0_default_state>; > + > + status = "okay"; > +}; > + > +&pcie0_phy { > + vdda-phy-supply = <&vreg_l1e_0p88>; > + vdda-pll-supply = <&vreg_l3e_1p2>; Super nit: add newline for consistency. > + status = "okay"; > +}; > + > +&pcie1 { > + wake-gpios = <&tlmm 99 GPIO_ACTIVE_HIGH>; > + perst-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>; Neither controller needs the new enable gpio? > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie1_default_state>; > + > + status = "okay"; > +}; > + > +&pcie1_phy { > + vdda-phy-supply = <&vreg_l3c_0p91>; > + vdda-pll-supply = <&vreg_l3e_1p2>; > + vdda-qref-supply = <&vreg_l1e_0p88>; > + > + status = "okay"; > +}; > + > &pm8550_gpios { > sdc2_card_det_n: sdc2-card-det-state { > pins = "gpio12"; Johan