From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F14C1C433DB for ; Tue, 26 Jan 2021 17:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4C272224C for ; Tue, 26 Jan 2021 17:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393616AbhAZRzh (ORCPT ); Tue, 26 Jan 2021 12:55:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:52112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390565AbhAZIr5 (ORCPT ); Tue, 26 Jan 2021 03:47:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 323BD2065C; Tue, 26 Jan 2021 08:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611650836; bh=rng9Nb9+8117ydjRos2PO70jwsMyORCgsjpX+/KUosE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1V8UDm8mOOhsmNxbzJp34LP+DyptQ7n81ztp/vXlDzJCHm1MDdlCW1MjZFliX1P4 pOWnsrbxzvRqSTGyDUZ8D8k2/lKzKfE8ZVTWr6t3G3eVFf2yFB1RKJZI2HUkECJkDn 7Lhn+rEcVJLL8PY6/Xlk7Pmeq6ivl4Iht70MkC5A= Date: Tue, 26 Jan 2021 09:47:14 +0100 From: Greg Kroah-Hartman To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Anthony Iliopoulos , Mike Snitzer , Sasha Levin Subject: Re: [PATCH 4.19 12/58] dm integrity: select CRYPTO_SKCIPHER Message-ID: References: <20210125183156.702907356@linuxfoundation.org> <20210125183157.221452946@linuxfoundation.org> <20210125185829.GA2818@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210125185829.GA2818@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2021 at 07:58:29PM +0100, Pavel Machek wrote: > Hi! > > > From: Anthony Iliopoulos > > > > [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ] > > > > The integrity target relies on skcipher for encryption/decryption, but > > certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to > > compilation errors due to unresolved symbols. Explicitly select > > CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent > > on it. > > There is no such config option in 4.19. This patch is not suitable > here. > > grep -r CRYPTO_SKCIPHER . > ./include/crypto/skcipher.h:#ifndef _CRYPTO_SKCIPHER_H > ./include/crypto/skcipher.h:#define _CRYPTO_SKCIPHER_H > ./include/crypto/skcipher.h:#endif /* _CRYPTO_SKCIPHER_H */ > > Best regards, > Pavel > > > +++ b/drivers/md/Kconfig > > @@ -527,6 +527,7 @@ config DM_INTEGRITY > > select BLK_DEV_INTEGRITY > > select DM_BUFIO > > select CRYPTO > > + select CRYPTO_SKCIPHER > > select ASYNC_XOR > > ---help--- > > This device-mapper target emulates a block device that has Good catch, now dropped, thanks. greg k-h