RE: [EXT] Re: [PATCH v2 RFC net-next 03/18] net: mvpp2: add CM3 SRAM memory map

Stefan Chulski
2021-01-25T08:22:27Z

> > #include <linux/of_net.h>
> > #include <linux/of_address.h>
> > #include <linux/of_device.h>
> > +#include <linux/genalloc.h>
> > #include <linux/phy.h>
> > #include <linux/phylink.h>
> > #include <linux/phy/phy.h>
> > @@ -91,6 +92,18 @@ static inline u32 mvpp2_cpu_to_thread(struct
> mvpp2 *priv, int cpu)
> > return cpu % priv->nthreads;
> > }
> >
> > +static inline
> > +void mvpp2_cm3_write(struct mvpp2 *priv, u32 offset, u32 data) {
> > + writel(data, priv->cm3_base + offset); }
> > +
> > +static inline
> > +u32 mvpp2_cm3_read(struct mvpp2 *priv, u32 offset) {
> > + return readl(priv->cm3_base + offset); }
>
> No inline functions in .c file please. Let the compiler decide.
>
> Andrew

Ok, I would fix.

Thanks,
Stefan.