From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C07C433E0 for ; Mon, 25 Jan 2021 16:54:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB88E2223E for ; Mon, 25 Jan 2021 16:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728707AbhAYQxf (ORCPT ); Mon, 25 Jan 2021 11:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730700AbhAYQur (ORCPT ); Mon, 25 Jan 2021 11:50:47 -0500 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13AA9C0613D6 for ; Mon, 25 Jan 2021 08:50:05 -0800 (PST) Received: by mail-ot1-x331.google.com with SMTP id s2so11167503otp.5 for ; Mon, 25 Jan 2021 08:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FXiOGPJTStyVPkN5QR6IiZg8V0I4G7zzEe6ZPNG+tu0=; b=Tabny4UNbo2e/sg7eclt06kqT5ioZhKFjOQojGSDzhvOPAVSHL+pgXPwHpYl1ly2vm +Jsb/lqzz8CiL44bNN+hthgilh55llayuHVMtb+437Uef7PHx1kV8O3Dd4S3Kl0HbUew sbcvxxRnM2ZMO5T/64pEuMy2PB5uCgKcrF1qYgs7wtvrYCTB7q7m9z4XNd08QYvOWArN xvSqYSTy9Pug4H9H7Fq7nGSUNsK+pGovRNQiDpBFgKvnydiA3Xa1kCXVzRC1SM7S6+Qs kmnO/DgNb003FU+189Zk7xhdXh0jITq0VL9G50h0AtGaQ1fo/fd5/XwnTb1dozCnVSJ7 pDSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FXiOGPJTStyVPkN5QR6IiZg8V0I4G7zzEe6ZPNG+tu0=; b=J3vymqXZKJfXfXtEuvgfKnJ30moamUUuspiQZfiyPYUpTtCmgjrU6TSYKNmgRHGICz x1IFHSuObY1iMVN2BS/DJFLcbY9Cm0tupY81jzwBdQ/2kxqk9l0+Qv3/32YxOlJT4NXe acGCxY8OZDd0uatEUKSl0JZnvce6lCxQdZYdqTI8VbfSfkzK2Xy36D5PA5tZTTjimW0f GUdmwTqC0odJyW425+Q15tp8m19ln7VPW792mX7aUI0oU3CHkNlhf7Rq3bEZ71GIBwe+ UnxFCu/tNOu0QhdyyNJXJYRDr4CWhmrCAu47QM80mnLhpLx4uPMdENVydjxVgy+mJz7N 134g== X-Gm-Message-State: AOAM531m0B1CHEUTGs+sEiitdSguLKNChZUhs+XajnsKmJdMV/sZE/ql N4c+0GiybaIcoTCOsGxszB6yIg== X-Google-Smtp-Source: ABdhPJwa37NdGl0h6SNNYtodzUCLuxnziGC5ipaC8v4/Ne5doejFqNHW7GfaAqTxW/v6trTIszI2LA== X-Received: by 2002:a9d:27c6:: with SMTP id c64mr1053724otb.313.1611593404407; Mon, 25 Jan 2021 08:50:04 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id o16sm3544458ote.79.2021.01.25.08.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 08:50:03 -0800 (PST) Date: Mon, 25 Jan 2021 10:50:01 -0600 From: Bjorn Andersson To: Robert Marko Cc: agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luka Perkov Subject: Re: [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node Message-ID: References: <20200907101937.10155-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907101937.10155-1-robert.marko@sartura.hr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 07 Sep 05:19 CDT 2020, Robert Marko wrote: > Since we now have driver for the SDHCI VQMMC LDO needed > for I/0 voltage levels lets introduce the necessary node for it. > > Signed-off-by: Robert Marko > Cc: Luka Perkov > --- > arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi > index 6741a1972e55..7774dbd3cec7 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi > @@ -211,6 +211,16 @@ tlmm: pinctrl@1000000 { > interrupts = ; > }; > > + vqmmc: regulator@1948000 { > + compatible = "qcom,vqmmc-ipq4019-regulator"; > + reg = <0x01948000 0x4>; The actual hardware block where this register is found is the "TCSR" which is 0x01947000 of size 0x21000 - making this the register at offset 0x11000. Perhaps it would have been better represented as a simple-mfd with this regulator as a child node thereof. That said, this has been sitting long enough, so I'll merge it as is and we can rework it once we need more pieces of tcsr. Thanks, Bjorn > + regulator-name = "vqmmc"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <3000000>; > + regulator-always-on; > + status = "disabled"; > + }; > + > sdhci: sdhci@7824900 { > compatible = "qcom,sdhci-msm-v4"; > reg = <0x7824900 0x11c>, <0x7824000 0x800>; > -- > 2.26.2 >