Re: [PATCH v4 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps

Minchan Kim
2021-01-27T03:17:57Z

On Tue, Jan 26, 2021 at 07:07:44AM +0000, Christoph Hellwig wrote:
> > +config DMABUF_HEAPS_CHUNK
> > + bool "DMA-BUF CHUNK Heap"
> > + depends on DMABUF_HEAPS && DMA_CMA
> > + help
> > + Choose this option to enable dma-buf CHUNK heap. This heap is backed
> > + by the Contiguous Memory Allocator (CMA) and allocates the buffers that
> > + are arranged into a list of fixed size chunks taken from CMA.
>
> Overly long line, which in text flowing text is really, really annoying.
>
> Many more later. Remember that > 80 chars are only allowed if they
> significantly improve readability.

Let me make it shorter than 80 chars in next revision.
Thanks for the reivew, Christoph.