From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACD0C433DB for ; Fri, 15 Jan 2021 11:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98775221F7 for ; Fri, 15 Jan 2021 11:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbhAOLbt (ORCPT ); Fri, 15 Jan 2021 06:31:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:34474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbhAOLbs (ORCPT ); Fri, 15 Jan 2021 06:31:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610710261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3GHz8S+62EVlouf3aCzWVck64PnR00Hq4PvSyTaWKW8=; b=n26BaUW3wpEbyCAcOmUAJLIHtBqYO1mLmPuRM387wc9pLOC1ebtXfeNwSTFuRHas/AkOxh e+RFHz4+nticbLh7EuygbHmmwzxK2KoqIqxCSb+jk5LCVvNVTfSZZb5YYJ9u86LxH6JqHT m6tr3Nu/9k26Uzx6SoUMhk2cPhxK4i0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72544B80E; Fri, 15 Jan 2021 11:31:01 +0000 (UTC) Date: Fri, 15 Jan 2021 12:31:00 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: fix kmsg_dump_get_buffer length calulations Message-ID: References: <20210113164413.1599-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113164413.1599-1-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2021-01-13 17:50:13, John Ogness wrote: > kmsg_dump_get_buffer() uses @syslog to determine if the syslog > prefix should be written to the buffer. However, when calculating > the maximum number of records that can fit into the buffer, it > always counts the bytes from the syslog prefix. > > Use @syslog when calculating the maximum number of records that can > fit into the buffer. > > Fixes: e2ae715d66bf ("kmsg - kmsg_dump() use iterator to receive log buffer content") > Signed-off-by: John Ogness The patch is committed in printk/linux.git, branch printk-rework. I plan to send it for-5.11 the following week after it spends few days in linux-next. Best Regards, Petr