From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01498C433DB for ; Fri, 15 Jan 2021 10:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4EDD235F9 for ; Fri, 15 Jan 2021 10:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729959AbhAOKJo (ORCPT ); Fri, 15 Jan 2021 05:09:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:50854 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727184AbhAOKJn (ORCPT ); Fri, 15 Jan 2021 05:09:43 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610705337; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4Faumz9gT2pY3vY0mqp7ThUzNaq8hQ/0YmK2KtYGiqU=; b=PikZd6Loq/f4lJ+0IwfPS4ziRz35aVE9uvjHZIwv3nfwj4vHIdyBtSUTm6roFQZCfNII9N hAx4VOnTH24PH3u6SUQTuEqb4uhDFA/h43axBKJ4eX3JsSJgPEP7DeB8NvzK6zuADoKoQv 8480w8AivaghOJFUj+u26EGpztI/4vg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 543BCB7C6; Fri, 15 Jan 2021 10:08:57 +0000 (UTC) Date: Fri, 15 Jan 2021 11:08:55 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: chenzhou Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() Message-ID: References: <20201218061755.121205-1-chenzhou10@huawei.com> <7804658e-7644-8edb-5ca8-0c97389c8c62@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aW+Hjh85VlI7M/Bn" Content-Disposition: inline In-Reply-To: <7804658e-7644-8edb-5ca8-0c97389c8c62@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --aW+Hjh85VlI7M/Bn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou = wrote: > Yeah, this will select all enabled controllers, but which doesn't the beh= avior we want. I see what the issue is now. > See above. Just the mount behavior isn't what we what. I agree this a bug and your I find your approach correct Reviewed-by: Michal Koutn=FD > The behavior was changed since commit f5dfb5315d34 ("cgroup: take > options parsing into ->parse_monolithic()"), will add this as Fixes. Thanks. Michal --aW+Hjh85VlI7M/Bn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAmABabMACgkQia1+riC5 qSgNFg/9HhaSDxHBhPH86Pcz71+vllYTelnF1P8Bgbquc6o7w6cFhAsmQh9LpwpI zHp+FSSxSzkdW7kjQpQpVPnmyUVvroFYqkLl2htJQMF8F6DfR1XlqtR47xOfqbDL 54slEHktuATW7SxwGu6P8wAE/Orq3gelNarEaW2I+nH3bg0SAUkdj6ThhbwZF9Tk 1Fd5AttK8/727Gw67YBl13CN8EYol8AfG+qC1SRtdtTSrk50EF9mLZy8PtlyYyyl CYSetNahCaKaoYzBjl0UJQ8d3CPt8LAxyEMgjW/oieD7rYDyLffaqh7GcfXbFVpt yBCIG4CWGlyDDqdJbXUA645nvXGUDGOB6K0cOTUBZlMPmHB/g0QJi6Mr7bMJ6XuN gg5dhMcLLAbIoZfUmMsCjUOr+r5hShnId2L+0XLuzgFA6wYR2oV/2EAfmjXPKcGF nznrKyYld8okjzYe/3SAwq5VJ/P71rwjIbHAxB/aVWpL0Kr7WQl0ygoknm4Lsx3r zy9vMomoF1PibdROuX7Cuv1CDkullQsInTS4B33Wh8dtQjJRcZH8Kdkz2QwyXww3 IBQ+dYPV9ZSEAfRk1WRT4bGXmV4dLJIUWNuhwCTYkVG2KqKD7BiUfLGfDuzm3syR BkXq0TXboV8LDaLliErZqwQcQJU9RjSz9UiPgHMXSmE/bKFk5QM= =I1mY -----END PGP SIGNATURE----- --aW+Hjh85VlI7M/Bn--