From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5328AC433DB for ; Fri, 15 Jan 2021 13:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 156BE221E2 for ; Fri, 15 Jan 2021 13:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732595AbhAONOg (ORCPT ); Fri, 15 Jan 2021 08:14:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731646AbhAONOf (ORCPT ); Fri, 15 Jan 2021 08:14:35 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11E77C061757 for ; Fri, 15 Jan 2021 05:13:55 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id u14so3370725wmq.4 for ; Fri, 15 Jan 2021 05:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2g4u3xNSMK8ghZXqKFL1R16HFSl2YerHraRE1h1ytpo=; b=NJnjEoGtqvon0egRK9YDpRFtOVbouVzaWgRbvYfVii+pcX8Ains4e8W1vQK2TqkAOX yJ+CaqAjsp/dYPpBhRRVqsJ50qnOF64iyVZz5gsAoZiYdsB7AJsJ86Dk/jIiH9jdAW7u S2lpxb2tRpaTTc94ebf7nepCVudFXT9rCksZcU/vPJ4mU/wq06zc03tPavGYoFzj48OD mf090vFhbR24JxJnLVx/wcDpnu4RWfAArLaMzN5z0plP5un+8hjwky/AjLPZrND5ddd6 hdqWlLONDBuo3ylfSdJ1j/zS/5DgBHxK/D1fJlkWcQIlg6TjqIfMSzGRac6mDARTo+FP h/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2g4u3xNSMK8ghZXqKFL1R16HFSl2YerHraRE1h1ytpo=; b=CCT6aaK6WTA+ibke0vK4bYp9cq2Cr/4z+5VOi1jgXml2WA4FtVLgt/NVgo2Ob8oQEz 9u/oo9+aOa/mOiHxotYmRN9TkiqvebCebCQCQD4yeJqBiC9UixaENuNObEvtUfdIb+5U 9PMEPRmLHJ2ELkc2kuTOMLt7VRbeGk8pw+ZLo51P2o7deStg7vT3PKGs3hEKuF6wFF1t UJw+8Xo3/eq2A4nK4J+Mi9AhVMry+kc+HXCvPEYy9VSNyb+HGqDGUHjjJ5J/R65Tc5Io Rxrr/pxuf2NYl+E00crC1KQihew7pHptEKsrsHxkXFqXRnmIJ/k2r9mokObNSM+7386Z lKsQ== X-Gm-Message-State: AOAM530sDM9sTB1KYwrqCWAWsSKdT5CzBmM2dUjdy8/LMseuW5JEWuwv NIqT2/mMAM5lxhX+BSZXsy0h9Q== X-Google-Smtp-Source: ABdhPJxfOZhdwQYrDchMipN1IZpHmQWkJDk+mAZz8JHVlnN1ck11zGlbUHx0lY6QrlOT4n4wgqVJvA== X-Received: by 2002:a1c:9acb:: with SMTP id c194mr8510839wme.43.1610716433539; Fri, 15 Jan 2021 05:13:53 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id x17sm14605648wro.40.2021.01.15.05.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 05:13:52 -0800 (PST) Date: Fri, 15 Jan 2021 14:13:47 +0100 From: Marco Elver To: Andrey Konovalov Cc: Andrew Morton , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 15/15] kasan: don't run tests when KASAN is not enabled Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.2 (2020-11-20) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 08:36PM +0100, Andrey Konovalov wrote: > Don't run KASAN tests when it's disabled with kasan.mode=off to avoid > corrupting kernel memory. > > Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > lib/test_kasan.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index a96376aa7293..6238b56127f8 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -47,6 +47,11 @@ static bool multishot; > */ > static int kasan_test_init(struct kunit *test) > { > + if (!kasan_enabled()) { > + kunit_err(test, "can't run KASAN tests with KASAN disabled"); > + return -1; > + } > + > multishot = kasan_save_enable_multi_shot(); > hw_set_tagging_report_once(false); > return 0; > -- > 2.30.0.284.gd98b1dd5eaa7-goog >