Re: [PATCH v2 04/19] scsi: mvsas: Pass gfp_t flags to libsas event notifiers

Ahmed S. Darwish
2021-01-12T17:05:26Z

On Tue, Jan 12, 2021 at 03:46:42PM +0000, Christoph Hellwig wrote:
> > } else if (mwq->handler & EXP_BRCT_CHG) {
> > phy->phy_event &= ~EXP_BRCT_CHG;
> > - sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD);
> > + sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD, GFP_ATOMIC);
>
> Please don't add pointless lines > 80 chars. This seems to happen a lot
> more in the series.

I didn't break the lines because they will be modified at the end of the
series anway.

When the _gfp() suffix is removed (patches #13 => #19), the lines get
within the 80 cols range.

Thanks,

--
Ahmed S. Darwish
Linutronix GmbH