From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9515CC433E0 for ; Sun, 17 Jan 2021 15:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C16B2251F for ; Sun, 17 Jan 2021 15:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729538AbhAQPpy (ORCPT ); Sun, 17 Jan 2021 10:45:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:49472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728700AbhAQPpr (ORCPT ); Sun, 17 Jan 2021 10:45:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A768A2251F; Sun, 17 Jan 2021 15:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610898307; bh=t3zZcca4zIt6z+nrt4nmiIyB8hCcHff/IjNUqqEK1Ps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1vpgxM/fA2X7wQwKNpj3U12JWlBiCNTFJBfI1KKGzNa5akhAqL+NDAZfzx8VOjKzY Pnm6Ej5+gzBmdX8XkjZa4j8nGfwku5yfRNjqGcXY9BwMU9CEKM0Q+rz/r6ruvsxEn6 PVRVHefdo8eg6wmZU9QVEJoFtRdGxI6SNGITVaEY= Date: Sun, 17 Jan 2021 16:45:04 +0100 From: Greg KH To: Xu Yilun Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com, lgoncalv@redhat.com, hao.wu@intel.com Subject: Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices Message-ID: References: <1610502848-30345-1-git-send-email-yilun.xu@intel.com> <1610502848-30345-2-git-send-email-yilun.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610502848-30345-2-git-send-email-yilun.xu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the uio_pdrv_genirq > platform device with the DFL device's resources, and let the generic UIO > platform device driver provide support to userspace access to kernel > interrupts and memory locations. Why doesn't the existing uio driver work for this, why do you need a new one? > --- > drivers/fpga/Kconfig | 10 +++++ > drivers/fpga/Makefile | 1 + > drivers/fpga/dfl-uio-pdev.c | 93 +++++++++++++++++++++++++++++++++++++++++++++ uio drivers traditionally go in drivers/uio/ and start with "uio", so shouldn't this be drivers/uio/uio_dfl_pdev.c to match the same naming scheme? But again, you need to explain in detail, why the existing uio driver doesn't work properly, or why you can't just add a few lines to an existing one. thanks, greg k-h