From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2217C433E6 for ; Mon, 18 Jan 2021 13:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E9B82225C for ; Mon, 18 Jan 2021 13:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391180AbhARN5a (ORCPT ); Mon, 18 Jan 2021 08:57:30 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59051 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404779AbhARNz5 (ORCPT ); Mon, 18 Jan 2021 08:55:57 -0500 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2332920008; Mon, 18 Jan 2021 13:55:07 +0000 (UTC) Date: Mon, 18 Jan 2021 14:55:07 +0100 From: Paul Kocialkowski To: Julia Lawall Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, =?utf-8?B?S8OpdmluIEwnaMO0cGl0YWw=?= , Sakari Ailus , linux-kernel@vger.kernel.org, Linux Memory Management List , kbuild-all@lists.01.org Subject: Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QNxCC/ko3tLIeCxU" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QNxCC/ko3tLIeCxU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > From: kernel test robot >=20 > PTR_ERR should access the value just tested by IS_ERR Good catch! Reviewed-by: Paul Kocialkowski Cheers, Paul > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci >=20 > Fixes: 11c0d8fdccc5 ("media: i2c: Add support for the OV8865 image sensor= ") > CC: Paul Kocialkowski > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall > --- >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: b3a3cbdec55b090d22a09f75efb7c7d34cb97f25 > commit: 11c0d8fdccc56fa15cb15906480b4737c31dd085 [2650/3956] media: i2c: = Add support for the OV8865 image sensor > :::::: branch date: 2 days ago > :::::: commit date: 4 days ago >=20 > ov8865.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > --- a/drivers/media/i2c/ov8865.c > +++ b/drivers/media/i2c/ov8865.c > @@ -2849,7 +2849,7 @@ static int ov8865_probe(struct i2c_clien > sensor->avdd =3D devm_regulator_get(dev, "avdd"); > if (IS_ERR(sensor->avdd)) { > dev_err(dev, "cannot get AVDD (analog) regulator\n"); > - ret =3D PTR_ERR(sensor->dvdd); > + ret =3D PTR_ERR(sensor->avdd); > goto error_endpoint; > } >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --QNxCC/ko3tLIeCxU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmAFkzsACgkQ3cLmz3+f v9FKbQf+NcZH7Muof9WMCk2hCgMCuDHJPB+r4d23+jph+8Z55rc0NvIIzZLiFO/v YdaRBSz14ar2gMp4o8lifD3AQxKEvyCga90LqwJ329WpHvk4E8SKW0KI7jNv5XWU EWR7LVxSrunBYwt7lYAiP0By6KWpDxvrXPfk6fLvbvxG0xH+ewaZ557xvh976uRr jpCZNx93uT8XKW5dutl2zLz3MLhyRWm0s46yeGHX5VJk3BdfCNTF9heApuuy0Oiu zvf0yXjHk4Z4NQypzveWg8ekdKHe/rfZosWsaBkSrVmK5fXZVPVOw1nDo8PCs+jf 1sZbPyTNC/qySeSiLDY+J4/mjU8vvw== =oRMb -----END PGP SIGNATURE----- --QNxCC/ko3tLIeCxU--