From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>, Al Cooper <alcooperx@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: bdc: Remove the BDC PCI driver
Date: Mon, 18 Jan 2021 18:37:02 +0100 [thread overview]
Message-ID: <YAXHPk+kAGY45cgN@kroah.com> (raw)
In-Reply-To: <CAMeQTsbQcbrBMvh2uzPjCJ1bMDQtZTEUMJ9Y9mhmGTnxhN-3+A@mail.gmail.com>
On Mon, Jan 18, 2021 at 01:54:16PM +0100, Patrik Jakobsson wrote:
> On Mon, Jan 18, 2021 at 1:22 PM Felipe Balbi <balbi@kernel.org> wrote:
> >
> >
> > Hi,
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> > >> Al Cooper <alcooperx@gmail.com> writes:
> > >> > The BDC PCI driver was only used for design verification with
> > >> > an PCI/FPGA board. The board no longer exists and is not in use
> > >> > anywhere. All instances of this core now exist as a memory mapped
> > >> > device on the platform bus.
> > >> >
> > >> > NOTE: This only removes the PCI driver and does not remove the
> > >> > platform driver.
> > >> >
> > >> > Signed-off-by: Al Cooper <alcooperx@gmail.com>
> > >>
> > >> It sounds like it could be used for pre-silicon verification of newer
> > >> Core Releases, much like Synopsys still uses the HAPS (with mainline
> > >> linux, mind you) for silicon validation.
> > >>
> > >> Why would we delete this small shim if it *could* still be useful?
> > >
> > > It ends up conflicting with the PCI id of a device that is actually in
> > > the wild (a camera on Apple laptops). So it's good to drop this driver
> > > so the wrong driver doesn't get constantly bound to the wrong device.
> >
> > I see. Oh well...
>
> It would also help if this got disabled in stable so existing kernels
> stop loading bdc.
>
> Can this patch go directly into stable or should I send a patch that
> adds "depends on BROKEN"?
A patch for that, that I can take now for 5.11-final and backport to
stable kernels would be fine.
thanks,
greg k-h
prev parent reply other threads:[~2021-01-18 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 21:31 [PATCH] usb: bdc: Remove the BDC PCI driver Al Cooper
2021-01-15 23:15 ` Florian Fainelli
2021-01-18 11:30 ` Felipe Balbi
2021-01-18 11:37 ` Greg Kroah-Hartman
2021-01-18 12:22 ` Felipe Balbi
2021-01-18 12:54 ` Patrik Jakobsson
2021-01-18 17:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAXHPk+kAGY45cgN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox