Re: [PATCH v6 11/15] phy: tegra: xusb: Add wake/sleepwalk for Tegra210

Thierry Reding
2021-01-19T23:53:13Z

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

On Tue, Jan 19, 2021 at 04:55:42PM +0800, JC Kuo wrote:
> This commit implements Tegra210 XUSB PADCTL wake and sleepwalk
> routines. Sleepwalk logic is in PMC (always-on) hardware block.
> PMC driver provides managed access to the sleepwalk registers
> via regmap framework.
>
> Signed-off-by: JC Kuo <jckuo@nvidia.com>
> ---
> v6:
> no change
> v5:
> no change
> v4:
> move sleepwalk/wake stubs from 'struct tegra_xusb_padctl_ops' to
> 'struct tegra_xusb_lane_ops'
> remove a blank line
> rename 'pmc_dev' with 'pdev'
> remove 'struct device_node *np'
> rename label 'no_pmc' with 'out'
> defer .probe() if PMC driver is yet to load
>
> v3:
> rename 'pmc_reg" with 'regmap' and move to the top of 'struct tegra210_xusb_padctl'
> change return data of .phy_remote_wake_detected() to 'bool'
> change input parameter of .phy_remote_wake_detected() to 'struct phy*'
> remove unnecessary 'else'
> rename 'val' with 'value'
> rename tegra_pmc_*() with tegra210_pmc_*()
> remove VBUS ON/OFF control change
>
> drivers/phy/tegra/xusb-tegra210.c | 930 ++++++++++++++++++++++++++++++
> 1 file changed, 930 insertions(+)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]