From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
x86 Maintainers <x86@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Giovanni Gherdovich <ggherdovich@suse.com>,
Giovanni Gherdovich <ggherdovich@suse.cz>
Subject: Re: [PATCH] x86: PM: Register syscore_ops for scale invariance
Date: Tue, 19 Jan 2021 17:03:02 +0100 [thread overview]
Message-ID: <YAcCtnYbhasv+ENi@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0gY+WjB2q=wnRYxpwFmLzOcLMKewrCgKdpC0oNPFgoDww@mail.gmail.com>
On Tue, Jan 19, 2021 at 04:12:20PM +0100, Rafael J. Wysocki wrote:
> On Tue, Jan 12, 2021 at 4:10 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > >
> > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > >
> > > > On x86 scale invariace tends to be disabled during resume from
> > > > suspend-to-RAM, because the MPERF or APERF MSR values are not as
> > > > expected then due to updates taking place after the platform
> > > > firmware has been invoked to complete the suspend transition.
> > > >
> > > > That, of course, is not desirable, especially if the schedutil
> > > > scaling governor is in use, because the lack of scale invariance
> > > > causes it to be less reliable.
> > > >
> > > > To counter that effect, modify init_freq_invariance() to register
> > > > a syscore_ops object for scale invariance with the ->resume callback
> > > > pointing to init_counter_refs() which will run on the CPU starting
> > > > the resume transition (the other CPUs will be taken care of the
> > > > "online" operations taking place later).
> > > >
> > > > Fixes: e2b0d619b400 ("x86, sched: check for counters overflow in frequency invariant accounting")
> > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > Thanks!, I'll take it through the sched/urgent tree?
> >
> > That works, thanks!
>
> Any news on this front? It's been a few days ...
My bad, it's been held up behind me trying to fix another sched
regression. Lemme push out just this one so it doesn't go walk-about.
next prev parent reply other threads:[~2021-01-19 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 18:05 [PATCH] x86: PM: Register syscore_ops for scale invariance Rafael J. Wysocki
2021-01-11 18:36 ` Giovanni Gherdovich
2021-01-12 15:01 ` Peter Zijlstra
2021-01-12 15:10 ` Rafael J. Wysocki
2021-01-19 15:12 ` Rafael J. Wysocki
2021-01-19 16:03 ` Peter Zijlstra [this message]
2021-01-19 16:09 ` [tip: sched/urgent] " tip-bot2 for Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAcCtnYbhasv+ENi@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ggherdovich@suse.com \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox