From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A114FC433E0 for ; Tue, 19 Jan 2021 16:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5ED7921D1B for ; Tue, 19 Jan 2021 16:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391506AbhASQHk (ORCPT ); Tue, 19 Jan 2021 11:07:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391385AbhASQD4 (ORCPT ); Tue, 19 Jan 2021 11:03:56 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A50DC061575; Tue, 19 Jan 2021 08:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EhVNN5w31+BoStuV5p83fjIjrTbho1tnvewJve+/h9Q=; b=UWCs2GbaEiVNzA19wKWlr9c/PQ UMAZuyoJbhGdlV8lgXLhfgFbaPPe7Lpsa68jxwobKbaLIK+P95bRELv5UA3iWDav8I5VDBfvkedFS L655rampQgJNMFtqTyNpv4zhDBCk/jYsuzhSepx26gdFHNwfX1Uc1s17Q8QY/zMfurFb/78c8Y0we MDdUdDeZ+qlSShuLda/IkktpDC0tDiIidFBkainB86N45fT63FFku/gyzrJFqNzf7dmi9FK1xiQOb CPyBMTYfs8OAwFR4XgeYhEW+k1h+t85peDC+ohOBO0BCTXoWjFUiCPrp3agxiORyWrL6fKJt+QkvY IKD6dfBg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1tTE-0007Eu-LV; Tue, 19 Jan 2021 16:03:04 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 104D53059DD; Tue, 19 Jan 2021 17:03:03 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 02B0A202638D9; Tue, 19 Jan 2021 17:03:02 +0100 (CET) Date: Tue, 19 Jan 2021 17:03:02 +0100 From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux PM , LKML , x86 Maintainers , Srinivas Pandruvada , Giovanni Gherdovich , Giovanni Gherdovich Subject: Re: [PATCH] x86: PM: Register syscore_ops for scale invariance Message-ID: References: <1803209.Mvru99baaF@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 04:12:20PM +0100, Rafael J. Wysocki wrote: > On Tue, Jan 12, 2021 at 4:10 PM Rafael J. Wysocki wrote: > > > > On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra wrote: > > > > > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > On x86 scale invariace tends to be disabled during resume from > > > > suspend-to-RAM, because the MPERF or APERF MSR values are not as > > > > expected then due to updates taking place after the platform > > > > firmware has been invoked to complete the suspend transition. > > > > > > > > That, of course, is not desirable, especially if the schedutil > > > > scaling governor is in use, because the lack of scale invariance > > > > causes it to be less reliable. > > > > > > > > To counter that effect, modify init_freq_invariance() to register > > > > a syscore_ops object for scale invariance with the ->resume callback > > > > pointing to init_counter_refs() which will run on the CPU starting > > > > the resume transition (the other CPUs will be taken care of the > > > > "online" operations taking place later). > > > > > > > > Fixes: e2b0d619b400 ("x86, sched: check for counters overflow in frequency invariant accounting") > > > > Signed-off-by: Rafael J. Wysocki > > > > > > Thanks!, I'll take it through the sched/urgent tree? > > > > That works, thanks! > > Any news on this front? It's been a few days ... My bad, it's been held up behind me trying to fix another sched regression. Lemme push out just this one so it doesn't go walk-about.