From: Peter Zijlstra <peterz@infradead.org>
To: vincent.donnefort@arm.com
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
valentin.schneider@arm.com
Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()
Date: Wed, 20 Jan 2021 18:54:43 +0100 [thread overview]
Message-ID: <YAhuY6PyqnNDyY44@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YAgr8RQg6Cn66bvf@hirez.programming.kicks-ass.net>
On Wed, Jan 20, 2021 at 02:11:14PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote:
> > @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum cpuhp_state state,
> >
> > if (st->fail == state) {
> > st->fail = CPUHP_INVALID;
> > -
> > - if (!(bringup ? step->startup.single : step->teardown.single))
> > - return 0;
> > -
> > return -EAGAIN;
> > }
> >
> > + if (cpuhp_step_empty(bringup, step)) {
> > + WARN_ON_ONCE(1);
> > + return 0;
> > + }
>
> This changes the behaviour of fail.. might be best to refactor without
> changing behaviour.
>
Aah, the trick is in cpuhp_next_state() skipping empty states, so we'll
never get there.
next prev parent reply other threads:[~2021-01-20 17:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 17:10 [PATCH 0/4] cpu/hotplug: rollback and "fail" interface fixes vincent.donnefort
2021-01-11 17:10 ` [PATCH 1/4] cpu/hotplug: Allowing to reset fail injection vincent.donnefort
2021-01-11 17:10 ` [PATCH 2/4] cpu/hotplug: CPUHP_BRINGUP_CPU exception in " vincent.donnefort
2021-01-20 12:58 ` Peter Zijlstra
2021-01-20 15:17 ` Vincent Donnefort
2021-01-20 17:30 ` Peter Zijlstra
2021-01-11 17:10 ` [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() vincent.donnefort
2021-01-20 13:11 ` Peter Zijlstra
2021-01-20 17:54 ` Peter Zijlstra [this message]
2021-01-20 17:45 ` Peter Zijlstra
2021-01-20 17:53 ` Peter Zijlstra
2021-01-21 10:57 ` Vincent Donnefort
2021-01-21 11:18 ` Peter Zijlstra
2021-01-20 17:49 ` Peter Zijlstra
2021-01-11 17:10 ` [PATCH 4/4] cpu/hotplug: Fix CPU down rollback vincent.donnefort
2021-01-21 14:57 ` Peter Zijlstra
2021-01-21 15:43 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAhuY6PyqnNDyY44@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox