public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhou Wang <wangzhou1@hisilicon.com>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-accelerators@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Sihang Chen <chensihang1@hisilicon.com>
Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device
Date: Thu, 21 Jan 2021 10:45:49 +0100	[thread overview]
Message-ID: <YAlNTSOMmsFPFAhk@kroah.com> (raw)
In-Reply-To: <1611220154-90232-1-git-send-email-wangzhou1@hisilicon.com>

On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote:
> When IO page fault happens, DMA performance will be affected. Pin user page
> can avoid IO page fault, this patch introduces a new char device named
> /dev/uacce_ctrl to help to maintain pin/unpin pages. User space can do
> pin/unpin pages by ioctls of an open file of /dev/uacce_ctrl, all pinned
> pages under one file will be unpinned in file release process.

Also, what are you really trying to do here?  If you need to mess with
memory pages, why can't the existing memory apis work properly for you?
Please work with the linux-mm developers to resolve the issue using the
standard apis and not creating a one-off char device node for this type
of thing.

thanks,

greg k-h

  parent reply	other threads:[~2021-01-21  9:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:09 [PATCH] uacce: Add uacce_ctrl misc device Zhou Wang
2021-01-21  9:44 ` Greg Kroah-Hartman
2021-01-22 11:33   ` Zhou Wang
2021-01-22 11:38     ` Greg Kroah-Hartman
2021-01-21  9:45 ` Greg Kroah-Hartman [this message]
2021-01-21 10:18   ` Song Bao Hua (Barry Song)
2021-01-21 11:18     ` Greg Kroah-Hartman
2021-01-21 11:52       ` Song Bao Hua (Barry Song)
2021-01-21 12:12         ` Greg Kroah-Hartman
2021-01-21 10:44 ` kernel test robot
2021-01-21 11:43 ` kernel test robot
2021-01-21 11:43 ` [RFC PATCH] uacce: uacce_ctrl_open() can be static kernel test robot
2021-01-21 13:27 ` [PATCH] uacce: Add uacce_ctrl misc device kernel test robot
2021-01-21 17:16 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAlNTSOMmsFPFAhk@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=chensihang1@hisilicon.com \
    --cc=linux-accelerators@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox