From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A5BC433E0 for ; Thu, 21 Jan 2021 10:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2D61235E4 for ; Thu, 21 Jan 2021 10:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbhAUKXQ (ORCPT ); Thu, 21 Jan 2021 05:23:16 -0500 Received: from mga03.intel.com ([134.134.136.65]:56036 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbhAUKUn (ORCPT ); Thu, 21 Jan 2021 05:20:43 -0500 IronPort-SDR: 51fRsr49keQUVP/Sv0UmNEtwvoEvC3+KhUfIQLRicUBuYrZnVDPDp4yf90wLzksWBJWq5iqAwi Co2wTvWjR7kA== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="179332589" X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="179332589" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 02:18:56 -0800 IronPort-SDR: Eokc4XQnbp9MzSQi/L/39fhZWWjDql3WR7ucevTyf+OJ+D23NzyX6BvsX3dwqqwf0sqwyu96dt IqltuelJsLDw== X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="502108595" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 02:18:52 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l2X4D-007NQN-Nc; Thu, 21 Jan 2021 12:19:53 +0200 Date: Thu, 21 Jan 2021 12:19:53 +0200 From: Andy Shevchenko To: Yury Norov Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, linux-arch@vger.kernel.org, Geert Uytterhoeven , Yoshinori Sato , Rich Felker , Arnd Bergmann , Dennis Zhou , Andrew Morton , Wolfram Sang , David Sterba , Stefano Brivio , "Ma, Jianpeng" , Wei Yang , Josh Poimboeuf , Rasmus Villemoes Subject: Re: [PATCH 2/6] bitmap: move some macros from linux/bitmap.h to linux/bitops.h Message-ID: References: <20210121000630.371883-1-yury.norov@gmail.com> <20210121000630.371883-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121000630.371883-3-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 04:06:26PM -0800, Yury Norov wrote: > In the following patches of the series they are used by > find_bit subsystem. s/subsystem/API/ ... > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -7,6 +7,17 @@ > > #include > > +#define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) > +#define BITMAP_LAST_WORD_MASK(nbits) (~0UL >> (-(nbits) & (BITS_PER_LONG - 1))) Hmm... Naming here is not in the bitops namespace. I would expect BITS rather than BITMAP for these two. So, we have at least the following options: - split to a separate header, like bitmap_macros.h - s/BITMAP/BITS/ and either define BITMAP_* as respective BITS_* or rename it everywhere in bitmap.* - your variant - ...???... -- With Best Regards, Andy Shevchenko