From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B67C433E0 for ; Fri, 22 Jan 2021 07:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33DFE22DBF for ; Fri, 22 Jan 2021 07:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbhAVHoh (ORCPT ); Fri, 22 Jan 2021 02:44:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:42078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726644AbhAVHoS (ORCPT ); Fri, 22 Jan 2021 02:44:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 007F322DBF; Fri, 22 Jan 2021 07:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611301417; bh=6s8dyzyoPVLbWhDYMgL1F8LoDlDPt5FF8Zj53kV3mAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KfrVUnxMKWRy3l4OwAp6N6XZxPCKi4F+bj789X/Wkue+NYccwQyYR5AX1tIZBo0nq eZ8RVREqLWy7msLAbGnbI2DWoumRgWuSaJQNNXdZiCgOB6bIq1dEMORrm04HrENFpJ ANwRJ2iBG6VP7jJRscNGXz7e6jAjWkO1NOkL7HEs= Date: Fri, 22 Jan 2021 08:43:34 +0100 From: Greg Kroah-Hartman To: Jiri Slaby Cc: Linus Torvalds , linux-serial@vger.kernel.org, Christoph Hellwig , Al Viro , Linux Kernel Mailing List , Oliver Giles , Robert Karszniewicz Subject: Re: [PATCH 1/6] tty: implement write_iter Message-ID: References: <20210121090020.3147058-1-gregkh@linuxfoundation.org> <4ade6b19-dc9e-ef72-dcca-1ddaa8d6c5fd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ade6b19-dc9e-ef72-dcca-1ddaa8d6c5fd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 08:33:33AM +0100, Jiri Slaby wrote: > On 21. 01. 21, 19:42, Linus Torvalds wrote: > > On Thu, Jan 21, 2021 at 9:57 AM Greg Kroah-Hartman > > wrote: > > > > > > Incremental patches please as these are already in my public branches > > > and I would have to revert them and add new ones but that's messy, so > > > fixes on top is fine. > > > > Ok. And since I think you put that first tty_write conversion patch in > > a different branch from the tty_read one, I did the fixup patches for > > the two as separate patches, even though they really just do the exact > > same thing. > > > > So here's three patches: the two fixups for the hung_up_tty case, and > > the EOVERFLOW error case that Jiri also noted. I've also updated the > > 'tty-splice' branch if you prefer them that way. > > > > And I *should* say that I still haven't tested _any_ of the HDLC > > changes. I have no idea how to do that, and if somebody can point to a > > test-case (or better yet, actually has a real life situation where > > they use it and can test this all) it would be great. > > > > Jiri, any other issues, or any comment of yours I missed? I didn't do > > the min() thing, I find the explicit conditional more legible myself, > > but won't complain if somebody else then disagrees and wants to clean > > it up. > > I cannot find anything else. > > All three: > Reviewed-by: Jiri Slaby Thanks for the review, I'll go apply these in a bit... greg k-h