From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wesley Zhao <zhaowei1102@thundersoft.com>
Cc: akpm@linux-foundation.org, keescook@chromium.org,
tglx@linutronix.de, kerneldev@karsmulder.nl,
nivedita@alum.mit.edu, joe@perches.com, gpiccoli@canonical.com,
aquini@redhat.com, gustavoars@kernel.org, ojeda@kernel.org,
ndesaulniers@gooogle.com, linux-kernel@vger.kernel.org,
david@redhat.com, dan.j.williams@intel.com, guohanjun@huawei.com,
mchehab+huawei@kernel.org
Subject: Re: [PATCH v3 2/2] resource: Make it possible to reserve memory on 64bit platform
Date: Fri, 22 Jan 2021 18:31:01 +0200 [thread overview]
Message-ID: <YAr9xaQM3LTU8vfS@smile.fi.intel.com> (raw)
In-Reply-To: <1611330937-22654-3-git-send-email-zhaowei1102@thundersoft.com>
On Fri, Jan 22, 2021 at 07:55:37AM -0800, Wesley Zhao wrote:
> For now "reserve=" is limitied to 32bit,not available on 64bit
> platform,so we change the get_option() to get_option_ull(added in
> patch: commit 4b6bfe96265e ("lib/cmdline: add new function
> get_option_ull()"))
Do better grammar and punctuation.
"For now "reserve=" is limited to 32bit, and not available on 64bit platform,
so we change the get_option() to get_option_ull() which is added in the
previous patch."
But!
You don't need to alter cmdline.c at all, see memparse() for the details!
And you have been told already, look at other options. You failed to mentioned
in the cover letter what's wrong with recommended memmap= approach.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-22 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:55 [PATCH v3 0/2] Make it possible to reserve memory on 64bit platform Wesley Zhao
2021-01-22 15:55 ` [PATCH v3 1/2] lib/cmdline: add new function get_option_ull() Wesley Zhao
2021-01-22 16:27 ` Andy Shevchenko
2021-01-22 15:55 ` [PATCH v3 2/2] resource: Make it possible to reserve memory on 64bit platform Wesley Zhao
2021-01-22 16:31 ` Andy Shevchenko [this message]
2021-01-22 16:26 ` [PATCH v3 0/2] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAr9xaQM3LTU8vfS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=guohanjun@huawei.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=ndesaulniers@gooogle.com \
--cc=nivedita@alum.mit.edu \
--cc=ojeda@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhaowei1102@thundersoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox