From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA63C433DB for ; Fri, 22 Jan 2021 23:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F205A23B52 for ; Fri, 22 Jan 2021 23:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728385AbhAVXUm (ORCPT ); Fri, 22 Jan 2021 18:20:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728042AbhAVXUc (ORCPT ); Fri, 22 Jan 2021 18:20:32 -0500 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7752C0613D6 for ; Fri, 22 Jan 2021 15:19:51 -0800 (PST) Received: by mail-oi1-x229.google.com with SMTP id r189so7886053oih.4 for ; Fri, 22 Jan 2021 15:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rrEawmDhNbvC3ZRUyuDABJFIFtqmVIBXaZAG0SlGvVg=; b=kxD7UEa8PuSzjCxBMEbiSxHtWTdN+ivDj9bSFtvqip0S81TJ2+lX5RWSX95+hDn3aZ y5NEX6TAzs9Wpn6HoOPjV5tKJKwVT8lSazcG/ADK70BHaW+51D6d+eoBrMDX3OT0wN0C AVAdA6kzegrZl6qpWOStS6EcvE1jYO41qCAzEI384o5TQj+xslBm6r19k7TZfllB/89k L1cFHW7O7LAcWj2+ETQNnyVEKXO0CgqBOI6bHWSKjgs7rdQm1gL8DPznllOZjOMdG3nK led5SRVfrHOxMzpfxi02sJOt+86MBLmI3Z2h0baK7jbkUDbnh/xqLAcu6T1vQ9UVjAHV bAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rrEawmDhNbvC3ZRUyuDABJFIFtqmVIBXaZAG0SlGvVg=; b=keIT/07KBLN7v3/fAdZXzUqP3ZI74Cz7IhaGHmCG6XqVBWVoxfDenK9TJoKak744wq GkqBbVJMqd4iwGsXwDZlFoRsOnKtlpfLq7D5S/9HBJNkovnhgnE5naR+yrUx4T+j8eGF lw1dcKEsX7Rz5R2hWYj6UDQWbE6OdRxewthWnDbDvwyGTXFm7xtNhKGBxmuNDDz98bnZ 6LjVrbDyv+dE07FNkdFQoCuog905n9HwQu6knS/Y1h+ZM/gpa/ksOZ/HSh+sfG/gFKho uyosZNBuqGhjboIJNjivChA9XcSxcrc2oyEQJXB1f/T3iZ204e2atWjnoUwHmUH/Qhex 7dSw== X-Gm-Message-State: AOAM530u67rUyflwifQajwWRAe0u6xwBeouXFJl0uF/xcvPka0V9N7d4 nWXfn0QOnn7cnJ8XRgaP6gexuA== X-Google-Smtp-Source: ABdhPJyu+cUAY9TnRrBqDllGidzhQE9q/TrcaqMSMZFrIvNzemiGzngm8TzqmPB8i2CUVCtoNJE/0w== X-Received: by 2002:aca:dd08:: with SMTP id u8mr4782911oig.85.1611357590959; Fri, 22 Jan 2021 15:19:50 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x188sm1172940oif.46.2021.01.22.15.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 15:19:50 -0800 (PST) Date: Fri, 22 Jan 2021 17:19:48 -0600 From: Bjorn Andersson To: Linus Walleij Cc: Pan Bian , Andy Gross , MSM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] bus: qcom: Put child node before return Message-ID: References: <20210121114907.109267-1-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 22 Jan 16:47 CST 2021, Linus Walleij wrote: > On Thu, Jan 21, 2021 at 12:49 PM Pan Bian wrote: > > > Put child node before return to fix potential reference count leak. > > Generally, the reference count of child is incremented and decremented > > automatically in the macro for_each_available_child_of_node() and should > > be decremented manually if the loop is broken in loop body. > > > > Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") > > Signed-off-by: Pan Bian > > Reviewed-by: Linus Walleij > > Please submit this patch for inclusion through the ARM SoC tree. > Any objections to me picking it in the Qualcomm tree? Or that's what you indirectly meant? Regards, Bjorn