From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC8B2C433E0 for ; Wed, 27 Jan 2021 16:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AD0D60187 for ; Wed, 27 Jan 2021 16:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbhA0QrJ (ORCPT ); Wed, 27 Jan 2021 11:47:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:34016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhA0Qqp (ORCPT ); Wed, 27 Jan 2021 11:46:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED81F60187; Wed, 27 Jan 2021 16:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611765965; bh=tQQ1aMFx+Z32YsIj9q7WBQHGMTx/Enh3DKZ90xb1QQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EoNSHMDbU1bYSlMjVMjYCPjjNv7MFetOLU4OxDzbswODAMqfq2W6uwqbknRQuDp86 mtOUsFJq0ldbfJxxoRI3AgzDNNcZ8Hi1p4HDJvyN3uZgteOOwnYmTDEvEAU77ZPa1N QhUNAhtgEesnZ+yGY5TkRPrMne4OdlRIwvowJnMiRdqb1ffqoy8oErgcOs509O58UB 8g7wvSsAMegRm5xnksHuH4wRx7PhL4jYHs1t8w+GoxanFoIxBYk3C+KVy+pXiBZegb tv9N1LNEeW4xaDW03oHYZnWhldcwwGy4CiYjjsfMAedXn7Q4xQgJHqtL71ISqJnVqd mvbmm59FEZJFw== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1l4nxQ-0002EP-5w; Wed, 27 Jan 2021 17:46:16 +0100 Date: Wed, 27 Jan 2021 17:46:16 +0100 From: Johan Hovold To: Anant Thazhemadam Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/12] usb: misc: usbsevseg: update to use usb_control_msg_send() Message-ID: References: <20210126183403.911653-1-anant.thazhemadam@gmail.com> <20210126184030.915039-1-anant.thazhemadam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126184030.915039-1-anant.thazhemadam@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021 at 12:10:30AM +0530, Anant Thazhemadam wrote: > The newer usb_control_msg_{send|recv}() API are an improvement on the > existing usb_control_msg() as it ensures that a short read/write is treated > as an error, data can be used off the stack, and raw usb pipes need not be > created in the calling functions. > For this reason, instances of usb_control_msg() have been replaced with > usb_control_msg_send() appropriately. > > Signed-off-by: Anant Thazhemadam > --- > drivers/usb/misc/usbsevseg.c | 60 ++++++++++-------------------------- > 1 file changed, 17 insertions(+), 43 deletions(-) > > diff --git a/drivers/usb/misc/usbsevseg.c b/drivers/usb/misc/usbsevseg.c > @@ -99,15 +94,10 @@ static void update_display_mode(struct usb_sevsegdev *mydev) > if(mydev->shadow_power != 1) > return; > > - rc = usb_control_msg(mydev->udev, > - usb_sndctrlpipe(mydev->udev, 0), > - 0x12, > - 0x48, > - (82 * 0x100) + 10, /* (set mode) */ > - (mydev->mode_msb * 0x100) + mydev->mode_lsb, > - NULL, > - 0, > - 2000); > + rc = usb_control_msg_send(mydev->udev, 0, 0x12, 0x48, > + (82 * 0x100) + 10, /* (set mode) */ > + (mydev->mode_msb * 0x100) + mydev->mode_lsb, > + NULL, 0, 2000, GFP_KERNEL); > > if (rc < 0) > dev_dbg(&mydev->udev->dev, "mode retval = %d\n", rc); This function is called from resume() and reset_resume() where GFP_NOIO should be used (and is used for update_display_visual()) so I think you need to add a GFP flag argument here too. Looks good otherwise. Johan