Re: [PATCH V2] x86/mm: Tracking linear mapping split events

Tejun Heo
2021-01-27T21:40:09Z

Hello,

On Wed, Jan 27, 2021 at 01:32:03PM -0800, Dave Hansen wrote:
> >> arch/x86/mm/pat/set_memory.c | 117 ++++++++++++++++++++++++++++++++++
> >> include/linux/vm_event_item.h | 8 +++
> >> mm/vmstat.c | 8 +++
> >> 3 files changed, 133 insertions(+)
> >
> > So, now the majority of the added code is to add debugfs knobs which don't
> > provide anything that userland can't already do by simply reading the
> > monotonic counters.
> >
> > Dave, are you still set on the resettable counters?
>
> Not *really*. But, you either need them to be resettable, or you need
> to expect your users to take snapshots and compare changes over time.
> Considering how much more code it is, though, I'm not super attached to it.

Saravanan, can you please drop the debugfs portion and repost?

Thanks.

--
tejun