From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8E3C433E6 for ; Thu, 28 Jan 2021 05:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C6F64DD9 for ; Thu, 28 Jan 2021 05:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231174AbhA1F7b (ORCPT ); Thu, 28 Jan 2021 00:59:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:37304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbhA1F7Y (ORCPT ); Thu, 28 Jan 2021 00:59:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DA56461492; Thu, 28 Jan 2021 05:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611813523; bh=GEdC11JIthNvWqLvLzGyO7/UjMyrlohhCwoIECOZYK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QpDETxCIN+gp8KLLQWdOiKR1G2qIxOZaAm65VIhO0araXgUPy4ccRR/oMcjQtzhs9 4vuyL1yjQv5F9czvKHLsxTN684WUr4fwM2eyInKstHL72YpmW7y0mOdtQscbNs1eCu iZcgsnL8T5iBYgn3r5pyTiQX5Rs8wt/zsSY1lm1OURwW7x9OguL+R02T4h6NeDguX8 bdWZ7S9D8B6bb37kkporkSmyMvKbhLDqfsWIyfpZjWbSP3jwjFwix1Ikw/Gc7q3Q75 AiDdPlY1m2YMNobwhG5KEiN3uhFDoOq8KbiOWa1uSocpaqe4xVSV2GJhxbPv4A0F8E I2L4nNLxR1sAw== Date: Thu, 28 Jan 2021 07:58:38 +0200 From: Jarkko Sakkinen To: James Bottomley Cc: =?utf-8?Q?=C5=81ukasz?= Majczak , Guenter Roeck , "Tj (Elloe Linux)" , Dirk Gouders , Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls Message-ID: References: <20210123014247.989368-1-lma@semihalf.com> <20210125171846.GA31929@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 08:46:48AM -0800, James Bottomley wrote: > On Tue, 2021-01-26 at 16:46 +0100, Łukasz Majczak wrote: > > Hi Jarkko, Guenter > > > > Yes, here are the logs when failure occurs - > > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > > Look for a phrase "TPM returned invalid status" > > We've had other reports of this: > > https://lore.kernel.org/linux-integrity/ghsgagsnag.fsf@gouders.net/ > https://lore.kernel.org/linux-integrity/374e918c-f167-9308-2bea-ae6bc6a3d2e3@elloe.vision/ > > The problem is some TIS TPMs don't begin in the correct locality so we > have to set it. When I proposed the check, I also proposed a fix for > this problem: > > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/ > > But it's part of a series that never went upstream. Part of the reason > was Jarkko proposed the get/put patch to fix this instead, but that > never went upstream either. We need to decide an approach and apply > one or other fixes. Can you remind me what I proposed? I remember only proposing removing interrupt code. Can you pick up just 1/5 and 2/5 from that serieis and send them as a mini series? I had one remark for 1/5, which can be found here: https://lore.kernel.org/linux-integrity/20201024120744.GA32607@kernel.org/ I don't think there was never argument on locality changes. /Jarkko