From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34964C433DB for ; Sat, 30 Jan 2021 11:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB2F164DF5 for ; Sat, 30 Jan 2021 11:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230455AbhA3LwA (ORCPT ); Sat, 30 Jan 2021 06:52:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:58840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhA3Lv6 (ORCPT ); Sat, 30 Jan 2021 06:51:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 278D564DF5; Sat, 30 Jan 2021 11:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612007477; bh=1TiGTb8bXJFZSQogGr6Y36Vr+6eMgMN/eHqeJmvIpZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sNDc9N19ZS7e1IGwfePNA6IQjA/jlOQRQt58Id/oXteKZ5oSCdJHeiWKP4FV0q9oh JEcu1iLBKz8qjDLtSYKLr9ewpyT3xW2YxQV4B66JsIPoOeCpWH7NwG9YmW6J5SYOqD QPpvMHT5ZJJ5zU5BwhIV1pCpgPGT58TA+JTgcfEc= Date: Sat, 30 Jan 2021 12:51:14 +0100 From: Greg KH To: "Aviraj Cj (acj)" Cc: "davem@davemloft.net" , "kuznet@ms2.inr.ac.ru" , "yoshfuji@linux-ipv6.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" , Hangbin Liu , Jakub Kicinski Subject: Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition Message-ID: References: <20210129192741.117693-1-acj@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2021 at 11:31:11AM +0000, Aviraj Cj (acj) wrote: > > > On 30/01/21, 2:06 PM, "Greg KH" wrote: > > On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote: > > From: Hangbin Liu > > > > commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream. > > > > Based on RFC7112, Section 6: > > > > IANA has added the following "Type 4 - Parameter Problem" message to > > the "Internet Control Message Protocol version 6 (ICMPv6) Parameters" > > registry: > > > > CODE NAME/DESCRIPTION > > 3 IPv6 First Fragment has incomplete IPv6 Header Chain > > > > Signed-off-by: Hangbin Liu > > Signed-off-by: Jakub Kicinski > > Signed-off-by: Aviraj CJ > > --- > > include/uapi/linux/icmpv6.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h > > index 2622b5a3e616..9a31ea2ad1cf 100644 > > --- a/include/uapi/linux/icmpv6.h > > +++ b/include/uapi/linux/icmpv6.h > > @@ -137,6 +137,7 @@ struct icmp6hdr { > > #define ICMPV6_HDR_FIELD 0 > > #define ICMPV6_UNK_NEXTHDR 1 > > #define ICMPV6_UNK_OPTION 2 > > +#define ICMPV6_HDR_INCOMP 3 > > > > /* > > * constants for (set|get)sockopt > > -- > > 2.26.2.Cisco > > > > What do you mean by "internal review" and what am I supposed to do with > this patch? Same for the 2/2 patch in this series... > Sorry " internal review" added by mistake, this is the correct patch for v5.4 branch, pls let me if u want me to send it by correcting... Please fix and resend. thanks, greg k-h