From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DFBC433DB for ; Mon, 1 Feb 2021 07:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE04364E22 for ; Mon, 1 Feb 2021 07:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231740AbhBAHji (ORCPT ); Mon, 1 Feb 2021 02:39:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:39842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbhBAHj1 (ORCPT ); Mon, 1 Feb 2021 02:39:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B18864E22; Mon, 1 Feb 2021 07:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612165127; bh=rXTgEhvSR6W4sYPBq+m/nEqhZ92jWIC4mr9KkRrG9Us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IxTPxEwuiUIxxHtKQcwAEP+jEiTeI8pMcNwRrnxYMxB9EoJ7ldnUsMmow3IA0Zmon uuRUEL+RjSfKjmvNXtlZX9gZfugu8jP5y32Ry6ZuAtDe08aDbwV3ijvQ7lJQzynFxB zoLvdF52yaLYmguUHKf08WFhGPrZs5mv+SO+gT5s= Date: Mon, 1 Feb 2021 08:38:43 +0100 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Mans Rullgard , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] serial: 8250: add option to disable registration of legacy ISA ports Message-ID: References: <20210128172244.22859-1-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2021 at 09:25:33PM +0200, Andy Shevchenko wrote: > On Thursday, January 28, 2021, Mans Rullgard wrote: > > > On systems that do not have the traditional PC ISA serial ports, the > > 8250 driver still creates non-functional device nodes. This change > > makes only ports that actually exist (PCI, DT, ...) get device nodes. > > > > > > This is kinda ABI breakage. At least this will break x86 platforms with > HSUARTs (all modern ones) that are used in embedded systems. > > I think you would rather need an option to disable this and select it by > the platforms where it is known not to break anything. This option is behind CONFIG_EXPERT, if you set it, you know what you are doing, so that's fine. thanks, greg k-h