From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126BEC433DB for ; Mon, 1 Feb 2021 10:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77BDA64E0F for ; Mon, 1 Feb 2021 10:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232997AbhBAKV1 (ORCPT ); Mon, 1 Feb 2021 05:21:27 -0500 Received: from mga14.intel.com ([192.55.52.115]:28116 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232752AbhBAKVX (ORCPT ); Mon, 1 Feb 2021 05:21:23 -0500 IronPort-SDR: INRPGqexD9NLwoLsUxjkSbA7fMm4CfYOXYfDAmmo81TtqluJ0tjyfDHaJk4eowneEcQRnko2ny Gwa5bvBjpCOA== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="179886442" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="179886442" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 02:19:32 -0800 IronPort-SDR: ZvShelBViC+QoJw7CsRqYxq9B+j6EaXC5vdg3U9jWMc0d6I96+YSrWotYUxx5uRUqJP5pADF3K 9xpu7huXTtuw== X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="506784591" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 02:19:29 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l6WIo-0016BM-65; Mon, 01 Feb 2021 12:19:26 +0200 Date: Mon, 1 Feb 2021 12:19:26 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Joel Becker , Christoph Hellwig , Jonathan Corbet , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-doc , Linux Kernel Mailing List , Bartosz Golaszewski Subject: Re: [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations Message-ID: References: <20210129134624.9247-1-brgl@bgdev.pl> <20210129134624.9247-6-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2021 at 09:25:08PM +0100, Bartosz Golaszewski wrote: > On Fri, Jan 29, 2021 at 4:59 PM Andy Shevchenko > wrote: > > > > On Fri, Jan 29, 2021 at 02:46:21PM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > > > > +int __bitmap_equal(const unsigned long *bitmap1, > > > + const unsigned long *bitmap2, unsigned int nbits); > > > > Why not > > > > int __bitmap_equal(const unsigned long *bitmap1, const unsigned long *bitmap2, > > unsigned int nbits); > > > > and so on? > > > > It's even in 80 limit. > > > > I feel like this is purely a matter of taste. No rules define exactly > how the lines should be broken. I prefer the longer part to be below, > it just looks better to my eyes. In above case it's even logically better to split as I proposed. -- With Best Regards, Andy Shevchenko