From: "Theodore Ts'o" <tytso@mit.edu>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Joe Perches <joe@perches.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help?
Date: Mon, 1 Feb 2021 12:59:25 -0500 [thread overview]
Message-ID: <YBhBfdZecMscxPOE@mit.edu> (raw)
In-Reply-To: <CAKXUXMwtXTYfs_9Asnmpd09zsucg8tRehMi2Shv8V49H-rs4xA@mail.gmail.com>
On Mon, Feb 01, 2021 at 05:50:45PM +0100, Lukas Bulwahn wrote:
>
> Dwaipayan, there are two ways:
> - We build a bot listening to mailing lists and check. I like that
> implementation idea for various other checks.
> - Stephen Rothwell could include this as a check on linux-next and
> inform the git author and committer.
>
> I am wondering though if that is worth the effort, three instances of
> a wrong date among 1M commits seems to be very seldom and the harm of
> that mistake is quite small as well.
Another solution might be to ask the git developers if they would be
willing to have "git am" print a warning if the date is sufficiently
insane (say, more than 3 months in the past or present).
One could also imagine a request that "git log" would have a new
format where normally the author time is printed, but if it's
sufficiently different from the commit time, the commit time is also
printed in parenthesis.
Or you could set up your git config so that "git log" uses
--pretty=fuller by default, which prints both the author date and
commit date.
Like Lukas, I'm not really sure it's worth the effort, however.
- Ted
next prev parent reply other threads:[~2021-02-01 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:34 Patches from the future - can checkpatch help? Dwaipayan Ray
2021-02-01 16:37 ` [Linux-kernel-mentees] " Greg KH
2021-02-01 16:50 ` Lukas Bulwahn
2021-02-01 17:11 ` Dwaipayan Ray
2021-02-02 12:48 ` Joe Perches
2021-02-02 14:54 ` Philip Li
2021-02-01 17:59 ` Theodore Ts'o [this message]
2021-02-01 17:01 ` Dwaipayan Ray
2021-02-02 11:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBhBfdZecMscxPOE@mit.edu \
--to=tytso@mit.edu \
--cc=dwaipayanray1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox