From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91AAC433E0 for ; Mon, 1 Feb 2021 22:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABD2564EC6 for ; Mon, 1 Feb 2021 22:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhBAWee (ORCPT ); Mon, 1 Feb 2021 17:34:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:59826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbhBAWea (ORCPT ); Mon, 1 Feb 2021 17:34:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3685164E93; Mon, 1 Feb 2021 22:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612218830; bh=6ifs07SoPwNCF09AduweLP8VSa2eET6rB/VZr8wQPrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjc/+kX+QPWvs0PD/OViXtjsrmNHauL9Vd0DOYpMijrTS29Wm87KohdYqQqLWuwSm FhbIY4PvPkeCwz7nLF8fb6wbrFsrwuJCZPQ6ysZyFidn/W3lViZJ2Y5UhLHU7v9ag6 TGExqJGtp6hFB4E8lVUp34nS5Z966yrYvM7CEZCVGJ6KLwFLKh17KMj8WpHHKx6LIa e+0HYVsvx05hKmsRIwpTLRyg3HaRo+znAXLOBj0On2a+LgO785NVNP7/jBWfSqVlVc A9HEIwpC2sYWsL3NRKzIT94yaabrSOsNo9IMatWOXf7TQTAG9OVqY7l9jffQIpSs3K s+Kcz1abhVeUw== Date: Mon, 1 Feb 2021 14:33:48 -0800 From: Jaegeuk Kim To: Daeho Jeong Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Subject: Re: [PATCH] f2fs: prevent setting ioprio of thread not in merge mode Message-ID: References: <20210201005749.2980575-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201005749.2980575-1-daeho43@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks. Merged into the original patch. On 02/01, Daeho Jeong wrote: > From: Daeho Jeong > > It causes a crash to change the ioprio of checkpoint thread not in > checkpoint=merge. I fixed that to prevent setting the ioprio of the > thread when checkpoint=merge is not enabled. > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/sysfs.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 100608bcd517..e38a7f6921dd 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -357,8 +357,12 @@ static ssize_t __sbi_store(struct f2fs_attr *a, > return -EINVAL; > > cprc->ckpt_thread_ioprio = IOPRIO_PRIO_VALUE(class, data); > - ret = set_task_ioprio(cprc->f2fs_issue_ckpt, > - cprc->ckpt_thread_ioprio); > + if (test_opt(sbi, MERGE_CHECKPOINT)) { > + ret = set_task_ioprio(cprc->f2fs_issue_ckpt, > + cprc->ckpt_thread_ioprio); > + if (ret) > + return ret; > + } > > return count; > } > -- > 2.30.0.365.g02bc693789-goog