From: Benson Leung <bleung@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kyle Tso <kyletso@google.com>,
heikki.krogerus@linux.intel.com, bleung@chromium.org,
badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision
Date: Tue, 2 Feb 2021 07:10:14 -0800 [thread overview]
Message-ID: <YBlrVgJJMXqiocv7@google.com> (raw)
In-Reply-To: <YBlrGTaJQp/pCeJK@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Tue, Feb 02, 2021 at 04:09:13PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 07:02:52AM -0800, Benson Leung wrote:
> > Hi Kyle,
> >
> > On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote:
> > > typec_partner_set_pd_revision doesn't need any return value.
> > >
> > > Fixes: 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
> > > Signed-off-by: Kyle Tso <kyletso@google.com>
> >
> > Review tags for <bleung@chromium.org>
>
> What does that mean?
>
> Please respond with a line that I can use...
>
Reviewed-by: Benson Leung <bleung@chromium.org>
Sorry.
Benson
> thanks,
>
> greg k-h
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-02-02 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:55 [PATCH] usb: typec: Return void in typec_partner_set_pd_revision Kyle Tso
2021-02-02 15:02 ` Benson Leung
2021-02-02 15:09 ` Greg KH
2021-02-02 15:10 ` Benson Leung [this message]
2021-02-02 15:20 ` Heikki Krogerus
2021-02-02 18:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBlrVgJJMXqiocv7@google.com \
--to=bleung@google.com \
--cc=badhri@google.com \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox