Re: [RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

Krzysztof Wilczyński
2021-02-06T23:32:22Z

Hi Gustavo,

[...]
> +The interaction with this driver is done through the module parameter and
> +can be changed in runtime. The driver outputs the requested command state
> +information to /var/log/kern.log or dmesg.

The driver does not seem to offer any parameters (aside of using sysfs
for runtime settings), and it also seem to only print what it's doing
when debug level is enabled - unless I am missing something?

[...]
> +Request to stop any current TLP transfer:
> +- Command:
> + echo 1 > /sys/kernel/dw-xdata-pcie/stop
[...]

When I do the following:

# echo 1 > /sys/kernel/dw-xdata-pcie/write
# echo 1 > /sys/kernel/dw-xdata-pcie/stop
# cat /sys/kernel/dw-xdata-pcie/write

Would output from cat above simply show "0 MB/s" then? I wonder how
someone using this new driver could tell whether "write" or "read"
traffic generation has been enabled aside of reading the sysfs files,
would adding "/sys/kernel/dw-xdata-pcie/active" be an overkill here?

What do you think?

Krzysztof