From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8B7C4332B for ; Thu, 4 Feb 2021 14:57:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2427264F60 for ; Thu, 4 Feb 2021 14:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237046AbhBDO5P (ORCPT ); Thu, 4 Feb 2021 09:57:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:45476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236960AbhBDOyu (ORCPT ); Thu, 4 Feb 2021 09:54:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 222AB64F4D; Thu, 4 Feb 2021 14:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612450449; bh=F8e5Tfs+0+dMxhX3r0RE96VAf6DE6tlY4KDDXyE/GLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ORPNu+5bXFexfQJ92eaq58Qp6ZZuITVcdddmQtQnyEO3kb8O6mxS5SEs0WqmccRih uF1ruXcFkZMK4rHDyGZZFdTjGFg72XTN4brEobXlD1Ujy/MeFcD3riwtMWrefFFCpC wRq9bO/ic6vRKFMEHfgtlgOI0xRKais6VtaXD4P2EyGGNpoT6qU/0un7xhAWVdq9gr gbLT/tW21jm9O46UwWBqxNy6NITZD0D9/isSckjsG7F1eXoloL3+1MXqgOSh2BO+zQ zLTtWHRP4wLBIrR8cOV7bTwc9LW9e6EuwjpfWNbWAr9vCkxOF+L941iQ8oi4yY4F3Z nNPb4Y+08sCUg== Date: Thu, 4 Feb 2021 16:54:01 +0200 From: Jarkko Sakkinen To: Eric Snowberg Cc: dhowells@redhat.com, dwmw2@infradead.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] certs: include prototype for load_certificate_list Message-ID: References: <20210204033208.1389901-1-eric.snowberg@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204033208.1389901-1-eric.snowberg@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 10:32:08PM -0500, Eric Snowberg wrote: > The build test robot reports the following when building > with -Wmissing-prototypes > > int load_certificate_list(const u8 cert_list[], > ^ > certs/common.c:6:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > int load_certificate_list(const u8 cert_list[], > ^ > static > 1 warning generated. > > Fix the warning by including the header file. > > Signed-off-by: Eric Snowberg > Reported-by: kernel test robot Acked-by: Jarkko Sakkinen BTW, should the bot have reported-by tagged? /Jarkko > --- > certs/common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/certs/common.c b/certs/common.c > index 83800f51a1a1..16a220887a53 100644 > --- a/certs/common.c > +++ b/certs/common.c > @@ -2,6 +2,7 @@ > > #include > #include > +#include "common.h" > > int load_certificate_list(const u8 cert_list[], > const unsigned long list_size, > -- > 2.18.4 > >