* [PATCH] certs: include prototype for load_certificate_list
@ 2021-02-04 3:32 Eric Snowberg
2021-02-04 14:54 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Eric Snowberg @ 2021-02-04 3:32 UTC (permalink / raw)
To: dhowells, dwmw2; +Cc: keyrings, linux-kernel, eric.snowberg
The build test robot reports the following when building
with -Wmissing-prototypes
int load_certificate_list(const u8 cert_list[],
^
certs/common.c:6:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int load_certificate_list(const u8 cert_list[],
^
static
1 warning generated.
Fix the warning by including the header file.
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reported-by: kernel test robot <lkp@intel.com>
---
certs/common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/certs/common.c b/certs/common.c
index 83800f51a1a1..16a220887a53 100644
--- a/certs/common.c
+++ b/certs/common.c
@@ -2,6 +2,7 @@
#include <linux/kernel.h>
#include <linux/key.h>
+#include "common.h"
int load_certificate_list(const u8 cert_list[],
const unsigned long list_size,
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] certs: include prototype for load_certificate_list
2021-02-04 3:32 [PATCH] certs: include prototype for load_certificate_list Eric Snowberg
@ 2021-02-04 14:54 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2021-02-04 14:54 UTC (permalink / raw)
To: Eric Snowberg; +Cc: dhowells, dwmw2, keyrings, linux-kernel
On Wed, Feb 03, 2021 at 10:32:08PM -0500, Eric Snowberg wrote:
> The build test robot reports the following when building
> with -Wmissing-prototypes
>
> int load_certificate_list(const u8 cert_list[],
> ^
> certs/common.c:6:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int load_certificate_list(const u8 cert_list[],
> ^
> static
> 1 warning generated.
>
> Fix the warning by including the header file.
>
> Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
> Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
BTW, should the bot have reported-by tagged?
/Jarkko
> ---
> certs/common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/certs/common.c b/certs/common.c
> index 83800f51a1a1..16a220887a53 100644
> --- a/certs/common.c
> +++ b/certs/common.c
> @@ -2,6 +2,7 @@
>
> #include <linux/kernel.h>
> #include <linux/key.h>
> +#include "common.h"
>
> int load_certificate_list(const u8 cert_list[],
> const unsigned long list_size,
> --
> 2.18.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-04 3:32 [PATCH] certs: include prototype for load_certificate_list Eric Snowberg
2021-02-04 14:54 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox