public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Jason Li <jason.li@cortina-access.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
Date: Thu, 4 Feb 2021 16:49:52 +0100	[thread overview]
Message-ID: <YBwXoCwKwkcMPYvy@kroah.com> (raw)
In-Reply-To: <1612425530-20483-1-git-send-email-alex.nemirovsky@cortina-access.com>

On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote:
> +static uintptr_t *cortina_uart_ports;

Note, "uintptr_t" is not a valid kernel type.

Please use a pointer to a real thing, no void pointers please.

thanks,

greg k-h

  parent reply	other threads:[~2021-02-04 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1612425530-20483-1-git-send-email-alex.nemirovsky@cortina-access.com>
2021-02-04 15:48 ` [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform Greg Kroah-Hartman
2021-02-04 15:49 ` Greg Kroah-Hartman [this message]
2021-02-04 22:22   ` Alex Nemirovsky
     [not found] <1613702532-5096-1-git-send-email-alex.nemirovsky@cortina-access.com>
2021-03-23  9:22 ` Greg Kroah-Hartman
2021-03-23 19:28   ` Alex Nemirovsky
2021-03-24  6:04     ` Greg Kroah-Hartman
2021-03-23  9:24 ` Greg Kroah-Hartman
2021-03-23 19:25   ` Alex Nemirovsky
2021-03-24  6:02     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBwXoCwKwkcMPYvy@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alex.nemirovsky@cortina-access.com \
    --cc=jason.li@cortina-access.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox