From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB02C433DB for ; Wed, 17 Feb 2021 22:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C59E64E4B for ; Wed, 17 Feb 2021 22:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233534AbhBQWv5 (ORCPT ); Wed, 17 Feb 2021 17:51:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232953AbhBQWvq (ORCPT ); Wed, 17 Feb 2021 17:51:46 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A090C061756 for ; Wed, 17 Feb 2021 14:51:05 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id gx20so201606pjb.1 for ; Wed, 17 Feb 2021 14:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gWwYr0s0Pd0lrE6qpWWSKWiLIJ1ICefuI8SGvs5PCCI=; b=BwNEZo/uMnUvV84uNLV3wlI9IibOa+RKEp/9kxTKuAmnJLZcXhpudPHAJvEPVJjqyg CLnO11IA8QWPIXTX3gm6aU1pDPJpimH8EzKuKxZTuJxN+CZ/COpYtSOKnWlRyLGRr9cg oUEl+hTELV4NX+aMLxwObKsBJ+EgAN62bQOfQnYnJsguTWG2cTJOuqt3Lf2VvFfxG9C/ R9dYYXf4wJb7HK2xnf0svEOuwawqPgutBJDMelz/OnywFdmIgW8RJMj/gyKFLhjf5SfC G3t4cSm44H3qGb2tVoew+wnwHHNq9XOiCyPqD/fTt3nwCN6GmUeuSmMKLtquG2pCYwoM tE4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gWwYr0s0Pd0lrE6qpWWSKWiLIJ1ICefuI8SGvs5PCCI=; b=tA2WJBrcXQX7At1VYwAe05/VQm5tckZavwG1NQ8hHtVM73GPaIfefWReb2o4KZ8H/Z XAxUA5kRdkDWUQw4q0q4TMOEZrnwdkwt2a3iu7WrzcgwoQCMAOrOMo5j1AadL0APQEaQ mbWAKHDoA1dcwTGTtLoyFIvi/eJeOzsri7P0zDSaVTzoWxchQrurlCV/hukFJk4w07AW PTfBEVEhoujQ738m2kUehMf8GtozLyL0zILf+zD2AtWobzms125fe6jOY49o76EspMSG 9AwudunnR3ZxHMLz2AotgtGlnvudw7pG/AzUnyWpyjDA2CadMmaSrjTZCqaFYiVuHHpM g26A== X-Gm-Message-State: AOAM532bAlz+PSNkqIPSRydonEEu8S/XickLaNDriPXmmo/TXJV/FXHU aA6kowHy3/P0w/kUmMa69EpjPQ== X-Google-Smtp-Source: ABdhPJx9fClsRISNCiWm/gQ103a2Y9OtUG2MLjoFzn7CA4sDZy/+YZ1vnqhdpdDfd30MCJfDu9jOzw== X-Received: by 2002:a17:90b:1bcf:: with SMTP id oa15mr1043843pjb.78.1613602264695; Wed, 17 Feb 2021 14:51:04 -0800 (PST) Received: from google.com ([2620:15c:f:10:dc76:757f:9e9e:647c]) by smtp.gmail.com with ESMTPSA id q13sm2735111pfg.61.2021.02.17.14.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 14:51:04 -0800 (PST) Date: Wed, 17 Feb 2021 14:50:57 -0800 From: Sean Christopherson To: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon , Makarand Sonare Subject: Re: [PATCH 00/14] KVM: x86/mmu: Dirty logging fixes and improvements Message-ID: References: <20210213005015.1651772-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210213005015.1651772-1-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021, Sean Christopherson wrote: > Paolo, this is more or less ready, but on final read-through before > sending I realized it would be a good idea to WARN during VM destruction > if cpu_dirty_logging_count is non-zero. I wanted to get you this before > the 5.12 window opens in case you want the TDP MMU fixes for 5.12. I'll > do the above change and retest next week (note, Monday is a US holiday). Verified cpu_dirty_logging_count does indeed hit zero during VM destruction. Adding a WARN to KVM would require adding an arch hook to kvm_free_memslots(), otherwise the count will be non-zero if the VM is destroyed with dirty logging active. That doesn't seem worthwhile, so I'm not planning on pursuing a WARN for the upstream code.