* [PATCH] misc/pvpanic: Export module FDT device table
@ 2021-02-18 9:40 Shile Zhang
2021-02-18 10:00 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Shile Zhang @ 2021-02-18 9:40 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: linux-kernel, Shile Zhang
Export the module FDT device table to ensure the FDT compatible strings
are listed in the module alias. This help the pvpanic driver can be
loaded on boot automatically not only the ACPI device, but also the FDT
device.
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
---
drivers/misc/pvpanic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 41cab297d66e..2356d621967e 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
{ .compatible = "qemu,pvpanic-mmio", },
{}
};
+MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
static const struct acpi_device_id pvpanic_device_ids[] = {
{ "QEMU0001", 0 },
--
2.24.0.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] misc/pvpanic: Export module FDT device table
2021-02-18 9:40 [PATCH] misc/pvpanic: Export module FDT device table Shile Zhang
@ 2021-02-18 10:00 ` Greg Kroah-Hartman
2021-02-18 10:51 ` Shile Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-18 10:00 UTC (permalink / raw)
To: Shile Zhang; +Cc: Arnd Bergmann, linux-kernel
On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
> Export the module FDT device table to ensure the FDT compatible strings
> are listed in the module alias. This help the pvpanic driver can be
> loaded on boot automatically not only the ACPI device, but also the FDT
> device.
>
> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
> ---
> drivers/misc/pvpanic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 41cab297d66e..2356d621967e 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
> { .compatible = "qemu,pvpanic-mmio", },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
What caused this to not work properly? I.e. should there be a "Fixes:"
tag in the commit changelog as well?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] misc/pvpanic: Export module FDT device table
2021-02-18 10:00 ` Greg Kroah-Hartman
@ 2021-02-18 10:51 ` Shile Zhang
2021-02-18 12:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Shile Zhang @ 2021-02-18 10:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Arnd Bergmann, linux-kernel
On 2021/2/18 18:00, Greg Kroah-Hartman wrote:
> On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
>> Export the module FDT device table to ensure the FDT compatible strings
>> are listed in the module alias. This help the pvpanic driver can be
>> loaded on boot automatically not only the ACPI device, but also the FDT
>> device.
>>
>> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
>> ---
>> drivers/misc/pvpanic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
>> index 41cab297d66e..2356d621967e 100644
>> --- a/drivers/misc/pvpanic.c
>> +++ b/drivers/misc/pvpanic.c
>> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
>> { .compatible = "qemu,pvpanic-mmio", },
>> {}
>> };
>> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
>
> What caused this to not work properly? I.e. should there be a "Fixes:"
> tag in the commit changelog as well?
Sorry, I think it should be:
Fixes: 46f934c9a12fc ("misc/pvpanic: add support to get pvpanic device
info FDT")
Shall I sent v2 with this update?
Thanks!
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] misc/pvpanic: Export module FDT device table
2021-02-18 10:51 ` Shile Zhang
@ 2021-02-18 12:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-18 12:21 UTC (permalink / raw)
To: Shile Zhang; +Cc: Arnd Bergmann, linux-kernel
On Thu, Feb 18, 2021 at 06:51:08PM +0800, Shile Zhang wrote:
>
>
> On 2021/2/18 18:00, Greg Kroah-Hartman wrote:
> > On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
> > > Export the module FDT device table to ensure the FDT compatible strings
> > > are listed in the module alias. This help the pvpanic driver can be
> > > loaded on boot automatically not only the ACPI device, but also the FDT
> > > device.
> > >
> > > Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
> > > ---
> > > drivers/misc/pvpanic.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> > > index 41cab297d66e..2356d621967e 100644
> > > --- a/drivers/misc/pvpanic.c
> > > +++ b/drivers/misc/pvpanic.c
> > > @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
> > > { .compatible = "qemu,pvpanic-mmio", },
> > > {}
> > > };
> > > +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
> >
> > What caused this to not work properly? I.e. should there be a "Fixes:"
> > tag in the commit changelog as well?
>
> Sorry, I think it should be:
>
> Fixes: 46f934c9a12fc ("misc/pvpanic: add support to get pvpanic device info
> FDT")
>
> Shall I sent v2 with this update?
Yes please.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-18 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-18 9:40 [PATCH] misc/pvpanic: Export module FDT device table Shile Zhang
2021-02-18 10:00 ` Greg Kroah-Hartman
2021-02-18 10:51 ` Shile Zhang
2021-02-18 12:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox