From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E965C433E0 for ; Thu, 18 Feb 2021 14:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1599D64EAE for ; Thu, 18 Feb 2021 14:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhBRO0c (ORCPT ); Thu, 18 Feb 2021 09:26:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:48258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232879AbhBRMa4 (ORCPT ); Thu, 18 Feb 2021 07:30:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A269560C3D; Thu, 18 Feb 2021 12:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613650868; bh=1efNp6iCqT0cKOViZRtDzICFQx9Ge9hJLe5WpeuUQY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QGkRbO03z31FYI3sQ+BYTy4nZswN96ywJq44CWoNIJhfrY1g4iG+tb4M3rWsAgPYL y9WbrXLW/2HPh/sPq/wiwDPeYl36fGj1CLm5WWjAd6oGtfjlNgQKWO1srjDvd7W0oz 2izAQ9XUX8BMbF+6p6Q1MTmsx8tsgIxZt9n/lIoU= Date: Thu, 18 Feb 2021 13:21:05 +0100 From: Greg KH To: Atul Gopinathan Cc: Ian Abbott , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Message-ID: References: <20210218084404.16591-1-atulgopinathan@gmail.com> <8f73b7a1-02dd-32ef-8115-ad0f38868692@mev.co.uk> <20210218104755.GA7571@atulu-nitro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218104755.GA7571@atulu-nitro> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > On Thu, Feb 18, 2021 at 10:31:15AM +0000, Ian Abbott wrote: > > On 18/02/2021 08:44, Atul Gopinathan wrote: > > > Fix the following warning generated by sparse: > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces) > > > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist > > > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] * > > > > > > compat_ptr() has a return type of "void __user *" > > > as defined in "include/linux/compat.h" > > > > > > cmd->chanlist is of type "unsigned int *" as defined > > > in drivers/staging/comedi/comedi.h" in struct > > > comedi_cmd. > > > > > > Signed-off-by: Atul Gopinathan > > > --- > > > drivers/staging/comedi/comedi_fops.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > > > index e85a99b68f31..fc4ec38012b4 100644 > > > --- a/drivers/staging/comedi/comedi_fops.c > > > +++ b/drivers/staging/comedi/comedi_fops.c > > > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd, > > > cmd->scan_end_arg = v32.scan_end_arg; > > > cmd->stop_src = v32.stop_src; > > > cmd->stop_arg = v32.stop_arg; > > > - cmd->chanlist = compat_ptr(v32.chanlist); > > > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist); > > > cmd->chanlist_len = v32.chanlist_len; > > > cmd->data = compat_ptr(v32.data); > > > cmd->data_len = v32.data_len; > > > > > > > This patch and the other one in your series clash with commit 9d5d041eebe3 > > ("staging: comedi: comedi_fops.c: added casts to get rid of sparse > > warnings") by B K Karthik. > > Oh I see. Not sure if this is the right place to ask, but which tree and > branch should one work with when messing with the code in staging/ > directory? (wanted to avoid such clashes in future) staging-next is the best one to use from the staging.git tree. But as the above commit was merged in 5.9-rc1, way back in July of last year, I have no idea what tree you are currently using to not hit that... You should always be able to find the subsystem git trees in the MAINTAINERS file, or if not, just work off of what is in linux-next as that should have all subsystem's trees merged into it. thanks, greg k-h