From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB431C433E0 for ; Fri, 19 Feb 2021 03:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C3564ED5 for ; Fri, 19 Feb 2021 03:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbhBSDgp (ORCPT ); Thu, 18 Feb 2021 22:36:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhBSDgl (ORCPT ); Thu, 18 Feb 2021 22:36:41 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8B3C061574; Thu, 18 Feb 2021 19:36:01 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id s16so2596654plr.9; Thu, 18 Feb 2021 19:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bwui8jRScVwKr0ZT6q3CS0JkmV/YSF8KwvuD/o3Daac=; b=jxvT9loR4JAcMRScbE/sWr6VPhYv57R5sAN9pWv/8e7jNCKZJJ7WR3jBsdAzB2ft+3 UKYFZ08efrQzCp7QZCmLbYvNK1+zeN4IXV41yUHjbiVlpjTVQteewwsFdmnwEyT+M30A icGHbRmm+hH3YSRBruuCxvodxxE7LBYMPaqny4QnOodwYMP2NkP5cTUBubZ2yB4MDbIO surAohDFylkApDemH0+tCXeHcpT5mgZnsuREgkdV909h73AdnccwkZAZXLwD8zrvw+LM GZD7HKuVp16JBzMggmihvxfUMW5onpVSIOcgwH1qN0fqxT8qlYH4uotvlr27fB7pFbrj KJaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bwui8jRScVwKr0ZT6q3CS0JkmV/YSF8KwvuD/o3Daac=; b=OR6l/kU+ZgHDkP9zhc8SFO74oqUObAV1G0a9uzeyRnvQ5qOTK0ifmv/uuqd7ILZDAW BpUaK+u85RPnzSBxGTXgrPzsPkIhu/g+FmB9tOpu+M2ZSlypkk1Oz5tIqQd/6+15J9ac ppHa+uAOM7zZOnbPNfDLdMtLNHLVaf9OZ4E608xVBfLXxP57JXxFBAynYaEDlTp0l/bB 2MdwBjUEwghqYX5bk6Kk5rFnBPUwFiRTBffnGMTWdiWh50Na3dlg8UtoEcd98uCgRB7c F7trenoi4n6Ljv4nK0Ew/C49gzhArf5baInkzuaEq4YXcVC7edyXm2tRWMQ7ArkWOdnA zSbg== X-Gm-Message-State: AOAM533OZJIXyeqC3WD6oT9PdI+x6zS07dArt/xyIz3eXaS5POx771JO OGX+DVOHavPbfuoNWxLNo8M= X-Google-Smtp-Source: ABdhPJwce5FwMDtYrnUSFpL98MPO27Ip0K7LrWJtBtNXRvtVgoM+CFkj1Kj2eG8Hvtj8SblaLBYeHw== X-Received: by 2002:a17:90b:4b0f:: with SMTP id lx15mr7072656pjb.183.1613705761056; Thu, 18 Feb 2021 19:36:01 -0800 (PST) Received: from google.com ([2620:15c:202:201:8d20:87b2:91b7:7f7b]) by smtp.gmail.com with ESMTPSA id g3sm7622802pfq.42.2021.02.18.19.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 19:36:00 -0800 (PST) Date: Thu, 18 Feb 2021 19:35:57 -0800 From: Dmitry Torokhov To: kernel test robot Cc: Michael Srba , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: fix boolreturn.cocci warnings Message-ID: References: <202102181739.Tb984rzG-lkp@intel.com> <20210218095953.GA24768@4e7c6a388622> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218095953.GA24768@4e7c6a388622> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Feb 18, 2021 at 05:59:53PM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in function 'zinitix_init_touch' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Fixes: 26822652c85e ("Input: add zinitix touchscreen driver") > CC: Michael Srba > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: f40ddce88593482919761f74910f42f4b84c004b > commit: 26822652c85eff14e40115255727b2693400c524 Input: add zinitix touchscreen driver > > zinitix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/input/touchscreen/zinitix.c > +++ b/drivers/input/touchscreen/zinitix.c > @@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt > udelay(10); > } > > - return 0; > + return false; This is incorrect as function is trying to return error codes. It needs to be changed to return int. I'll take care of it. Thanks. -- Dmitry